Closed (fixed)
Project:
Commerce Features
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2011 at 03:39 UTC
Updated:
21 Jul 2015 at 18:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pcambraheh, yeah, you're right, I've updated the description in the module, I wonder if we're going to need to export payment entities as well...
Comment #2
rfayYeah, everything :-) Wish it was all ctools-exportable.
Comment #3
pcambraActually, product types and tax rates and types should be ctools doable just adding the export property to the schema as they're table based and the primary key is "simple".
The rest is code based so I'm not really sure if it's ctools exportable.
Comment #4
rfay@pcambra, Would love to have your input at #1319818: Exportables and Features integration for Drupal Commerce
Comment #5
pcambraOk, this one is slightly different as we don't create order types in commerce, so there's only one element to export just to leverage fields and dependencies to features.
Comment #6
rfayOoops.. I think we will in fact end up creating new order types. A client was proposing that yesterday and Ryan said that yes, that's a normal expectation, and will require code just like the line item code required.
Thanks for the effort on this!
Comment #7
pcambraLet's mark this as postponed until order type ui happens.
Comment #8
pcambraMaybe this project is worthy of follow: http://drupal.org/sandbox/manatwo/1341264
Comment #9
rfay@pcambra you're on top of things! Created today, no commits :-) I was thinking it was time to experiment with this. And there goes manatwo.
Comment #10
markwk commentedJust ran into this issue as I was working through the Order setup for creating a Marketplace. I was a bit surprised it couldn't be exported....
Comment #11
pcambra#10 you could try patch #5 and let me know if it works for you.
Comment #12
rfay#7 yeah, I added an order example in Commerce Examples, and it's hard to use without an Order UI. However, you can edit the code there and add fields, etc.
Comment #13
markwk commented@rfay: cheers for the starting point. That's really a bit help that example... thanks!
Comment #14
markwk commentedlooks like the patch has some issues with current stuff so I fixed it up and attached...
Comment #15
pcambraYeah, those are known issues :) you missed the actual include file for the features, though
Comment #16
markwk commentedforgot to do a "git diff --staged"
Comment #17
dabblela commentedI have committed working code to the commerce_order_types sandbox project and I'm working on getting this integration working. Unfortunately, #16 doesn't seem to work out of the box for the commerce_order_types module.
Comment #18
pcambraYes, this won't work "magically" with a custom implementation of a Order type UI, what this patch does is just to track fields in the existing order type. You'd need to implement some more code as we did for the line item types #1314706
Comment #19
dabblela commentedI have working code for the Commerce Order Types project; would it be better to work a generic implementation for export of order types? Unfortunately, there is no commerce order equivalent to commerce_line_item_types().
Comment #20
bojanz commentedWe can't do this until there's a full project for adding order types through the UI.
We made a decision with product types: only what's in the DB gets handled by features.
If there's only a hook, then that doesn't need features at all.
Comment #21
mparker17The Commerce order types module has a stable release now.
I've tried re-rolling the patch, but it currently doesn't pick up on the new order types defined by that module. I'll probably have to re-write the features-export part of it.
Comment #22
bojanz commentedLet's try this.
Comment #23
bojanz commentedAnd once again.
Comment #24
bojanz commentedFinal version, works in my testing.
Comment #25
bojanz commentedCommitted.
Comment #27
David Stosik commentedHello,
This does not work for me, I don't see commerce order types in the list of components available in features (drush features-components).
Commerce order and Commerce order types are enabled on my site.
Looking at the code, I see in commerce_features.module:49
'default_hook' => 'commerce_order_default_types',But I can't find commerce_order_default_types function anywhere. Is it expected to work as is?
Thank you,
David
Comment #28
David Stosik commentedHello, here's a follow-up:
I cannot export an order type using Drush, but I was able to do so using Features admin page.
Moreover, when I install and revert my feature on another site, the custom order types contained in my feature are not created. It looks like the implementation lacks something important...
David
Comment #29
bojanz commentedI have a production site using it successfully.
Let us know what you debugging finds.
Comment #30
David Stosik commentedYeah, sorry about that, the second part of my previous post (#28) was due to an older version of commerce_features installed on the target site.
Still, I can't export order types using Drush. Any idea about that?
David
Comment #31
bojanz commentedHaven't tested drush, so it's not impossible that there is a bug there.
Comment #32
mglamanExporting via Drush should be automatically handled through Features, not a special implementation. Moving back to Closed (fixed.)