Add rules condition that checks if order has discount

It doesn't need to know which discount?

Was thinking leave yours as default but provide an optional list parameter for discount references to check for?

It could be more complicated granted but that may cover off a few more use-cases, eh?

I've turned on the automated testing so we should probably add tests once the feature is decided.

"Most beneficial discount" is totally out of scope but interesting.

Tests aren't to hard there are lots of tests you can rip off in there already. Maybe give it a try and if you want just pseudo code the test and I can try and help write one.

1. +++ b/commerce_discount.rules.inc
   @@ -120,6 +120,17 @@ function commerce_discount_rules_condition_info() {
   +          'label' => t('Order')
   

   Nit: needs a comma at the end of each array item on it's own line. Coding Standards

2. +++ b/commerce_discount.rules.inc
   @@ -484,6 +495,33 @@ function commerce_order_has_specific_quantity_products_build(EntityDrupalWrapper
   +  // Check whether there is an order discount reference on the order.
   +  if (!empty($order->commerce_discounts)) {
   ...
   +  // Check whether there is a discount price component on the order.
   

   Is there any case where this check wouldn't suffice on it's own? And if not, do we also need to check each line item's components as well then?

3. +++ b/commerce_discount.rules.inc
   @@ -484,6 +495,33 @@ function commerce_order_has_specific_quantity_products_build(EntityDrupalWrapper
   +    return true;
   ...
   +        return true;
   ...
   +    return false;
   

   NIT: true to TRUE and false to FALSE for coding standards.

4. +++ b/commerce_discount.rules.inc
   @@ -484,6 +495,33 @@ function commerce_order_has_specific_quantity_products_build(EntityDrupalWrapper
   +    foreach ($order->commerce_order_total['und'][0]['data']['components'] as $value) {
   

   NIT: 'und' needs to be LANGUAGE_NONE constant please.

5. +++ b/commerce_discount.rules.inc
   @@ -484,6 +495,33 @@ function commerce_order_has_specific_quantity_products_build(EntityDrupalWrapper
   +      $array = str_getcsv($value['name'], '|');
   

   That's an interesting approach:) We've mostly been looping the components for this kind of check.

And lastly, this could totally use a test or two to make sure it's working and keeps working but I do like the idea and willing to commit it as I've heard this requested before regarding coupons.

+++ b/commerce_discount.rules.inc
@@ -484,6 +495,33 @@ function commerce_order_has_specific_quantity_products_build(EntityDrupalWrapper
+      $array = str_getcsv($value['name'], '|');
+      $component_has_discount = in_array('discount', $array);
+      if ($component_has_discount) {

Just a thought, why not:

strpos($value['name'], 'discount|') !== FALSE

Also, not sure how we could test the Rules integration, beyond forcing this file to be included and manually testing the function?

May be https://www.drupal.org/project/commerce_discount_cumulative could help you ?

It's built from another way. You do not define a condition : "Do not apply if another discount is already applied", but add cumulative option to each discount, so "Do not apply another discount after this discount", or "Remove other discounts, and only take this one".

If you really want "Do not apply if another discount is already applied", may be cumulative module can be updated to take care of this.

Do you really needs to put condition on coupon and not on discount ?
To my point of view, coupon is used to activate a discount, and it's the discount which should be configured to not be applied if another discount is used.

I think there is an issue in the way you are solving this issue right now. Each time cart is rebuilt, discounts are reseted and applied again, ordered by the rules weight.
* Create discount A + coupon with : "Do not apply if another discount is already applied" condition
* Create a discount B
If you apply coupon on your cart, i think both discounts will apply since discount B is created before discount A.

I create a module : https://www.drupal.org/project/commerce_discount_weight to handle discounts weight in discount edit form.

With commerce discount cumulative, you can only use 3 ways (also based on discount weight) :
* Allow to apply discounts after this discount
* Do not apply other discounts after this one (but keep previous)
* Do not apply other discounts after this one and remove previous

So, does adding "Do not apply this discount if another discount is already applied" option on discount (linked to you coupon) can match and solve your case ?

Please check out #2496051: Add rules condition that checks if order has discount and the API function it adds, commerce_discount_get_discounts_applied_to_price(). This inspects any price field to determine what discount related price components it contains. One thing it will not do is let you differentiate between discounts applied to an order vs. a product, but a condition based on this function could.

(Note: the reason I took that route instead of depending on the commerce_discounts field is because product level discounts still needed to be able to specify incompatibility with order level discounts.)

@AdamGerthel, the compatibility system alone may satisfy your initial requirements, regardless of whether or not we had a standalone condition for determining if an order was already discounted. Give it a whirl! : )

@rszrama: Your link is one back to this issue :)

lol, I do that all the time. : P

Correct link: #2557119: Allow discounts to indicate compatibility with other discounts

I'm not sure what you mean. In the latest version of Discount / Coupon, coupons and discounts are always tied together. You even create coupon codes using IEF in the discount add / edit form. I can't imagine there will be any work on branches that aren't the latest branch at this point in time.

Ahh, yeah, no worries. I was imprecise in my comment - Commerce Coupon 2.x is the latest version that should be used over 1.x, and it works with the latest release of Commerce Discount 1.x as I described above. I'll be working to get maintainer access on the Commerce Coupon project to fix up the messaging and recommended version ASAP.

#11 Patch works really well (thank you @AdamGerthel) until we updated the module. Is there any chance of rolling this into the next version of comerce Comerce Discounts for D7.