Hi! I've noticed that when I close the ctools modal window there is no animation, because the content is immediately removed.

I've created a patch to fix this issue.

Comments

yce’s picture

yce’s picture

Status: Active » Needs review
yce’s picture

Version: 7.x-1.7 » 7.x-1.9
StatusFileSize
new2.1 KB

Recreated patch for ctools 1.9 version.

chris matthews’s picture

Version: 7.x-1.9 » 7.x-1.x-dev

The 22 August 2015 patch in #3 to modal.js applied cleanly to the latest ctools 7.x-1.x-dev and if still applicable needs to be reviewed.

Checking patch js/modal.js...
Hunk #1 succeeded at 591 (offset 4 lines).
Applied patch js/modal.js cleanly.
joelpittet’s picture

Priority: Major » Normal
Status: Needs review » Fixed
StatusFileSize
new1.99 KB

Thanks I've committed a variation of this and left in the $(oldFocus).focus();

  • joelpittet committed 303be95 on 7.x-1.x authored by yce
    Issue #2493727 by yce, joelpittet, Chris2: Modal close animation not...
joelpittet’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.