move forum.theme.css to classy

moving forum css to classy :)

clean for testbot :)

+++ b/core/modules/forum/forum.libraries.yml
@@ -1,5 +0,0 @@
-forum.index:

+++ b/core/themes/classy/classy.libraries.yml
@@ -3,3 +3,9 @@ base:
+forum-index:

+++ b/core/themes/classy/templates/dataset/forums.html.twig
@@ -14,6 +14,7 @@
+{{ attach_library('classy/forum-index') }}

Make sure to use forum.index (instead of forum-index). I think that is causing the tests to fail.

I'll fix it.

The forum.libraries.yml was now empty. I feel like it's pointless to leave an empty library file there, so I removed it. Checking what testbot says about this patch.

Looks cool. Attached more shots.

$build['#attached']['library'][] = 'forum/forum.index';

in Drupal\forum\Controller\ForumController. With this patch that library would be missing.

I transferred the image and code to to classy, remove template for module and removed $build['#attached']['library'][] = 'forum/forum.index';

@Chernous_dn patch file is corrupt.. Can you please look into it.

I fix patch for #16 comment.

@Chernous_dn please update your git configuration to output easier to read patches for renames, most notably this chunk:

[diff]
  renames = copies

From https://www.drupal.org/documentation/git/configure

Thank you! :)

@Cottser Thanks)

Rerolled.

+++ b/core/themes/classy/classy.libraries.yml
rename from core/modules/forum/css/forum.theme.css
rename to core/themes/classy/css/forum/forum.theme.css

This should not go in a folder called 'forum'. It should go in the 'component' folder.

Folder fixed.

I think we'll need the weight change here. The file is ending up almost at the very end. I'm not sure why the ordering works out this way. Bartik and Classy are both added using component so why would Classy's end up so low?

with patch

after changing weight to -10

Here's the weight change.

Thanks, Marc. We'll need to test the forum icon. I can't test right now, but when I first tested this I did not see the icon appear. Can someone check that?

I tested the patch with Classy and we do have a problem with the icon image. It seems that it's being copied over corrupted. I also noticed that aren't escaping some stuff?

This should work

Fixed patch apply errors.

I can confirm the weight change from #30/31, but the new forum.css file isn't actually created so I'm missing the icons completely.

@akalata can you double-check? I just applied the patch and it worked for me. The file should be in classy/css/components/forum.css. Or are you saying you don't see it get added to a forum page? I do see the icons appearing. See screenshot.

One minor change. I renamed the library.

latest patch is working fine :)
Path of icon is /core/themes/classy/icons/forum-icons.png

Found my error, patch -p1 wasn't creating the new files, but git apply works.

I would set RTBC at this point, instead postponing per #2566771: [Voltron patch] Move all remaining *.theme.css to Classy.