Suggested commit message
Issue #2566771 by Cottser, mortendk, jstoller, LewisNyman, mdrummond, Gints Ērglis, sqndr, Chernous_dn, Manjit.Singh, axe312, emma.maria, davidhernandez, lauriii, jaxxed, akalata: [Voltron patch] Move all remaining *.theme.css to Classy
Problem/Motivation
See: #2489460: [Meta] Move module.theme.css files to Classy or Seven
All these patches conflict with each other.
Proposed resolution
Roll all the remaining module -> Classy issues into one patch once they have been tested and RTBC:
- #2489564: Move user.theme.css to Classy
- #2489566: move file.theme.css to classy
- #2489572: move forum.theme.css to classy
- #2489574: move image.theme.css to classy
- #2566823: Move dropbutton.theme.css to Classy
- #2566833: Move dialog.theme.css to Classy
Remaining tasks
Get all the above issues to RTBC
Postpone all issues
Create voltron patch
User interface changes
None for Classy/Bartik/Seven. Stark is more stark
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#25 | interdiff-22-25.txt | 716 bytes | gints.erglis |
#25 | voltron-theme-css-to-classy-2566771-25.patch | 19.48 KB | gints.erglis |
#22 | interdiff-19-22.txt | 30.67 KB | akalata |
#22 | voltron-theme-css-to-classy-2566771-22.patch | 19.45 KB | akalata |
#19 | voltron-theme-css-to-classy-2566771-19.patch | 50.09 KB | akalata |
Comments
Comment #2
LewisNyman CreditAttribution: LewisNyman at Wunder commentedComment #3
LewisNyman CreditAttribution: LewisNyman at Wunder commentedComment #4
LewisNyman CreditAttribution: LewisNyman at Wunder commentedComment #5
LewisNyman CreditAttribution: LewisNyman at Wunder commentedMoved #2489580: Move taxonomy.theme.css to Starterkit Theme and/or Claro to #2566775: [Voltron patch] Move all remaining *.admin.theme.css to Seven
Comment #6
RainbowArrayDropbutton is used by Quick Edit, so should maybe go in Seven with the funky stuff so that it works on the front-end even on non-Classy themes.
Comment #7
LewisNyman CreditAttribution: LewisNyman at Wunder commentedhmm, I have no idea how we can handle that, we have no way of specifying scope of CSS yet. Whichever CSS is loaded last would change all the dropbuttons on the page. I think I suggest a few ideas in #2195695: Admin UIs on the front-end are difficult to theme but nothing we can achieve in 8.0.0
Comment #8
davidhernandezI'm not to sure about moving drop button. Some will argue that should still work in Stark. I don't necessarily disagree with that argument.
Comment #9
LewisNyman CreditAttribution: LewisNyman at Wunder commentedIt functionally works in stark without the theme CSS but because it doesn't have a background color the actions don't stand out. I assume if people choose Stark they are going to implement their own dropbutton implementation using bootstrap or something, so the less we load the better?
Comment #10
RainbowArrayAll of the work we've done to make theming without Drupal's default classes getting in the way is undermined by this and related changes.
I would like to build themes off of core's clean markup, but if I have to reimplement all the front-end admin UI to do that, it is much less appealing.
I do not want to make the toolbar or the quick edit or the contextual links look different in a theme. I don't want to care about that at all. So anything that makes me think about that at all is a loss. I don't think I'm alone in this.
I just can't imagine there are that many people really wanting to start from scratch on admin UI for user-facing pages.
Comment #11
Manuel Garcia CreditAttribution: Manuel Garcia commentedI can perhaps see admin themes being happy about core not shipping frontend css for admin UI elements, other than that... not sure.
Comment #12
LewisNyman CreditAttribution: LewisNyman at Wunder commentedJust two patches left to review:
#2489564: Move user.theme.css to Classy #2489572: move forum.theme.css to classy
Comment #13
davidhernandezThere is still taxonomy.theme.css to move, right?
Comment #14
LewisNyman CreditAttribution: LewisNyman at Wunder commentedYes good catch. I've added it to the issue summary.
Comment #15
akalata CreditAttribution: akalata commented#2489580-29: Move taxonomy.theme.css to Starterkit Theme and/or Claro decided that taxonomy.theme.css is really admin css and should not be moved; all remaining Voltron pieces are ready to go!
Comment #16
akalata CreditAttribution: akalata commentedComment #17
akalata CreditAttribution: akalata commentedComment #18
LewisNyman CreditAttribution: LewisNyman at Wunder commentedThanks! This patch removes the files but it does not add the files into Classy. It's almost there, just be sure to
git add
the files.Comment #19
akalata CreditAttribution: akalata commentedThis patch definitely adds the new files, but has a bunch of whitespace errors that seem to be coming from the new/moved images? If I re-save the patch file in my editor, it removes those whitespace errors but gives me a corrupt file instead.
Comment #20
davidhernandezI believe all the no new line stuff is fine on binary files. They're not code files. I think it just does that automatically for any file.
Comment #21
star-szrAgreed with @davidhernandez that should be okay. Also adding the following to your .gitconfig will help a lot with making a smaller patch (detects renames):
That's one of the things on https://www.drupal.org/documentation/git/configure.
Comment #22
akalata CreditAttribution: akalata commentedThanks davidhernandez and Cottser!
Here's an updated, smaller patch. One thing I noticed -- file icons are being moved to themes/classy/images/icons, but the forum icon is only moving to themes/classy/icons. Not sure which is correct, but we should standardize.
Comment #23
LewisNyman CreditAttribution: LewisNyman at Wunder commentedAdded suggested commit message:
Issue #2566771 by Cottser, mortendk, jstoller, LewisNyman, mdrummond, Gints Ērglis, sqndr, Chernous_dn, Manjit.Singh, axe312, emma.maria, davidhernandez, lauriii, jaxxed, akalata: [Voltron patch] Move all remaining *.theme.css to Classy
Comment #24
LewisNyman CreditAttribution: LewisNyman at Wunder commented@akalata It seems like we should move all the icons into image/icons. Setting back to needs work to fix that.
Comment #25
gints.erglis CreditAttribution: gints.erglis commentedForum icons moved into image/icons.
Comment #26
gints.erglis CreditAttribution: gints.erglis commentedIgnore the interdiff-22-25.txt or read it from the other end.
Comment #27
jaxxed CreditAttribution: jaxxed at Wunder commentedlooks good to me.
- libraries are moved;
- hook is used to overload, and extend libraries in theme;
- icons are moved
- library_load is used in twig templates to load libraries.
Comment #28
webchickCommitted and pushed to 8.0.x. Thanks!
Comment #29
webchickSaving credit.
Comment #30
star-szrSmall follow-up: #2580049: Removed CSS files not removed from library definitions