Set cache contexts for exposed sorts / items_per_page / offset.

Looking good :)

Looks good. Only fixing a silly typo.

Even better!

That interdiff seems wrong; but no matter, it's still coming back red :(

This is not failing locally.

+++ b/core/modules/views/src/Tests/Plugin/ExposedFormTest.php
@@ -191,6 +195,54 @@ public function testInputRequired() {
+  protected function assertIds(array $ids) {

Missing PHP docs, fixed.

Daniel suggested to remove the verbose flag

I wish I was able to roll patches...
(interdiff in #17 is correct)

+++ b/core/modules/system/src/Tests/Cache/AssertPageCacheContextsAndTagsTrait.php
@@ -105,6 +105,8 @@ protected function assertCacheTags(array $expected_tags) {
+    sort($expected_contexts);
+    sort($actual_contexts);
     $this->assertIdentical($actual_contexts, $expected_contexts);

Is this really required? Why not use assertEqual then?

Because it's then easier to spot the errors. Cache::mergeContexts() also sorts them, so IMHO it makes sense to also have the expectation that the contexts are sorted in tests, and if necessary, sort them.

@Wim Leers fair enough - that makes sense.

This issue is a major task that will improve performance significantly and the disruption it introduces is limited. Per https://www.drupal.org/core/beta-changes, this is a good change to complete during the Drupal 8 beta phase. Committed 8e866ef and pushed to 8.0.x. Thanks!