OS Master is responsive Drupal theme that is not dependent on any core theme

Features:

  • Responsive
  • Creative Design
  • Drupal 7 Ready
  • Custom Theme Settings
  • Google Fonts Support
  • Font Awesome Integrated

Demo

Documentation

Automatic review
http://pareview.sh/pareview/httpgitdrupalorgsandboxordasoft2473355git

Link to project page
https://www.drupal.org/sandbox/ordasoft/2473355

Link to git
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Ordasoft/2473355.git os_master___responsive_drupal_theme

Links to reviews
https://www.drupal.org/node/2279781#comment-8972923
https://www.drupal.org/node/2278513#comment-8933673
https://www.drupal.org/node/2220943#comment-8937157

CommentFileSizeAuthor
master-main.png57.71 KBordasoft

Comments

me-great’s picture

Status: Needs review » Needs work

First of all please fix Automatic review warnings and errors

Next, you're including style_setting.php with <style>...</style> inside before <html> and <!DOCTYPE> tags.
I think that we can't go with that. Please at least include that code into <head></head>

Config standards and JS structure standards aren't met, please fix them.

Also I think it would be good if you use os_master template name instead of master. "Master" is too general word.

Next please move all variables calculations (i.e. $soc variable in page.tpl.php) to preprocess hooks.

ordasoft’s picture

Hello,

In our theme we haven't errors from Automatic review.
>The "?>" PHP delimiter at the end of files is discouraged, see https://www.drupal.org/node/318#phptags
>in file ./template/style_setting.php
look like errors self "pareview", because in that file not exist that error.(Or I not understand what that error mean)

Other warnings from "pareview" - also not full correct, because we define these variables in preprocess hooks

>Next, you're including style_setting.php with

...

inside before and tags
Fixed

>Config standards and JS structure standards aren't met, please fix them
Not understand what you mean, Can you give more details ?

>Also I think it would be good if you use os_master template name instead of master. "Master" is too general word.
Fixed

>Next please move all variables calculations (i.e. $soc variable in page.tpl.php) to preprocess hooks.
Fixed

Thanks

ordasoft’s picture

Status: Needs work » Needs review
PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2480797

Project 2: https://www.drupal.org/node/2395279

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

klausi’s picture

Status: Needs review » Closed (duplicate)

Let's keep the other open which already has a security issue reported.

avpaderno’s picture

Assigned: ordasoft » Unassigned
Related issues: +#2395279: [D7] Delta theme