unflagByFlagging() is only called in one place, and it's only a single line.

Also, it should not be called from outside the service, since that would bypass event triggering.

So the best thing I think would be to fold it into the calling method.

CommentFileSizeAuthor
#1 delete-2477781-1.patch1.23 KBmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107’s picture

martin107 CreditAttribution: martin107 commented
FileSize
delete-2477781-1.patch1.23 KB

I'd seen this before it was in the back of my mind....and thought the same thing.

its a self contained issue, easy to confirm, easy to solve.

There are lots of intricate intertwined issues coming into focus. My preference is to declutter the todo list by clearing all the isolatable ones early rather than adding to the flaggings metadata heap ;)

martin107’s picture

martin107 CreditAttribution: martin107 commented
Status: Active » Needs review
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Yup, cleaning up the small stuff to make it clearer to see what we're doing when we're refactoring is definitely a good way to go.

  • joachim committed 6557de7 on authored by martin107 
    Issue #2477781 by martin107: Removed FlagService::unflagByFlagging().

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.