There are a number of issues associated with Metatag's cache and there seems little in the way of benefit. Metatags are aimed at anonymous bot visitors so for most use cases, Drupal's page cache does the job of providing a cache layer for its output.

Dropping the cache would reduce the size and complexity of the module significantly and remove a major source of bugs and confusion for users.

CommentFileSizeAuthor
#5 metatag-n2474427-5.patch2.18 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.4 » 7.x-1.x-dev
Issue tags: +Performance

I think it's beneficial to keep the general configuration in cache, but maybe disabling the output cache might help? This could be an option on the settings page.

alfaguru’s picture

alfaguru commented

Damien, yes, my concerns are with the output cache, not with configuration. I am agnostic about the latter as it has not caused me any problems to date.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Drop the cache » Drop the output cache
thomwilhelm’s picture

thomwilhelm commented

+1 I'd also be keen to see this as an option in metatag, have run into issues recently with output keys over 128 causing conflict, all our pages are cached by varnish so there isn't any reason to separately cache the generated metatags.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2474427-5.patch2.18 KB

How does this work for you? It adds an option to the Advanced Settings page called 'Cache meta tag output' that is enabled by default but which controls whether meta tag output for entities is cached.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed deb98ec on 7.x-1.x 
    Issue #2474427 by DamienMcKenna: Added an advanced option to disable the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.