Move the "Draggable Table" Entity Reference Widget into it's own module [#2460503]

Problem/Motivation

I've been looking for a way to have a Nodequeue-like Entity Reference widget. Someone on IRC mentioned that this module has a widget that is really close to what I'm looking for (and would only require a slight modification for the publishing status. However, I don't need the rest of Entity Queue. :/

Proposed resolution

Move the "Draggable Table" Entity Reference widget into a submodule of this module (same project) and allow it to be installed independently of Entity Queue.

Comment	File	Size	Author
#1	dragtable-2460503-1.patch	27.13 KB	davidwbarratt
#1
#2	dragtable-2460503-2.patch	27.13 KB	davidwbarratt
#2
#4	dragtable-2460503-4.patch	27.16 KB	davidwbarratt
#4
#5	dragtable-2460503-5.patch	26.62 KB	davidwbarratt
#5
#5	interdiff-2460503-4-5.txt	889 bytes	davidwbarratt

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

davidwbarratt CreditAttribution: davidwbarratt at Golf Channel commented 1 May 2015 at 18:17

Version:	7.x-1.0-rc1	» 7.x-1.x-dev
Issue summary:	View changes
Status:	Active	» Needs review

File	Size
dragtable-2460503-1.patch	27.13 KB

Attached is a patch that moves the field formatter into a submodule of Entityqueue.

Comment #2

davidwbarratt CreditAttribution: davidwbarratt at Golf Channel commented 6 May 2015 at 12:04

File	Size
dragtable-2460503-2.patch	27.13 KB

1 file was hidden/shown/deleted

File	Size
dragtable-2460503-1.patch	27.13 KB

Fixed a typo in a function name.

Comment #3

jojonaloha CreditAttribution: jojonaloha commented 10 May 2015 at 07:28

Status:

Needs review

» Needs work

I think this is a good idea, and thought about doing this originally, but if I remember there were a few things I had a hard time separating.

Anyway, so far the patch looks good, but I notice the Reverse, Shuffle and Clear buttons don't function the way they did before. It seems they do take effect after you hit Save, but you don't get to preview the changes or know that it did anything. I think it's just that the ajax replacement of the form isn't happening anymore.

Comment #4

davidwbarratt CreditAttribution: davidwbarratt as a volunteer and commented 31 May 2015 at 15:40

File	Size
dragtable-2460503-4.patch	27.16 KB

1 file was hidden/shown/deleted

File	Size
dragtable-2460503-2.patch	27.13 KB

Rerolled patch.

I'll look into why the buttons are no longer working, I may have moved/removed something that was needed.

Comment #5

davidwbarratt CreditAttribution: davidwbarratt as a volunteer and commented 31 May 2015 at 15:56

Status:

Needs work

» Needs review

File	Size
dragtable-2460503-5.patch	26.62 KB

interdiff-2460503-4-5.txt	889 bytes

1 file was hidden/shown/deleted

File	Size
dragtable-2460503-4.patch	27.16 KB

Yep, looks like I accidentally removed the Ajax callback, I've added it back in this patch.

Comment #6

davidwbarratt CreditAttribution: davidwbarratt as a volunteer and commented 31 May 2015 at 15:56

Comment #7

albertski CreditAttribution: albertski at Xeno Media, Inc. commented 25 July 2016 at 18:05

Status:

Needs review

» Needs work

This patch is failing:

curl https://www.drupal.org/files/issues/dragtable-2460503-5.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 27260  100 27260    0     0  38783      0 --:--:-- --:--:-- --:--:-- 38776
patching file entityqueue.info
patching file entityqueue.module
Hunk #1 succeeded at 679 (offset -2 lines).
Hunk #2 FAILED at 836.
1 out of 2 hunks FAILED -- saving rejects to file entityqueue.module.rej
patching file includes/entityqueue.theme.inc
patching file js/entityqueue.widget.js
patching file modules/entityqueue_dragtable/entityqueue_dragtable.info
patching file modules/entityqueue_dragtable/entityqueue_dragtable.module
patching file modules/entityqueue_dragtable/includes/entityqueue.theme.inc
patching file modules/entityqueue_dragtable/js/entityqueue_dragtable.widget.js

Comment #8

jenlampton

she / her

CreditAttribution: jenlampton at Jeneration Web Development for BGP Site Solutions, Metropolitan Transportation Commission commented 22 August 2016 at 20:34

+1 for moving into another module. I am using entityqueue on several sites and some more jr developers keep using the super-buggy 'Draggable table' widget when it's completely unnecessary. I'd love to get rid of it until it stabilizes, it will keep my client complaints down :)