D7 Content Access VBO

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxscott_shipman2083709git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated review

:

1) Pareview.sh has issues.
2) Coder generated some critical errors.

Mahual Review

:

Git clone url
1) Your git clone url is incomplete, Please append the module name at the end of this url
git clone --branch 7.x-1.1 http://git.drupal.org/sandbox/scott_shipman/2083709.git
Because, this url is not letting us install the module on drupal instance.

README.txt:
1) This file is missing

.info file:
1) Unnecessary parameters present inside this file.
for ex : git & ;$Id$

.module file:
1) @file doc is missing.
2) form_constructor function content_access_vbo_action_form() needs to be defined properly, similarly for content_access_vbo_action_submit().
Please refer https://www.drupal.org/coding-standards/docs#forms
3) In function content_access_vbo_action_form(), you have used
4) '#title' => $label inside content_access_vbo_action_form() in module file. Translations are missing, please use t() function.

I have not enabled the module yet, And most important the code is actually not formatted.
Kindly correct.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi scott,

-remove the IDE settings from the repository

-please apply coding standards, it's a bit confusing

-the view needs admin to use(role based but with no roles by default) perhaps change it to to restrict by permission "Grant content access", or an own permission

-the action works even when per node settings not active - this is an inconsitent behaviour to base module
you should check this

-$_GET['type'] is used completely unchecked (and is handed to method of another module, where its f.e. used for output)
you could at least match against node_type_get_types()

-at least remove as much as possible from the http://pareview.sh/pareview/httpgitdrupalorgsandboxscottshipman2083709git
errors, in actual state its impossible to check if there are important messages in the list.

sugesstions:

-add package = Access control
to info file

-move your default view to an extra fileto clean up your module
follow naming convention yourmodule.views_default.inc should be sufficent

-consider using db_merge instead explicit check for existing record in content_access_vbo_action

Greetings
Peter

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.