Replace node_type Views handler with Field API formatter

index a3387be..69a3478 100644
--- a/core/modules/node/config/optional/views.view.content.yml

--- a/core/modules/node/config/optional/views.view.content.yml
+++ b/core/modules/node/config/optional/views.view.content.yml

Ts, you actually exported the view, and not just hacked the config directly.

Oops ok. Need to remove some of the yaml data. When we save handlers we should not keep old data. This seems to be what's happening?

Oops ok. Need to remove some of the yaml data. When we save handlers we should not keep old data. This seems to be what's happening?

Well the update you made is probably fine, the fails are unrelated.

Yep, definitely related :)

We have this todo in \Drupal\views\EntityViewsData::processViewsDataForEntityReference

    if ($field_definition->getName() == $this->entityType->getKey('bundle')) {
      // @todo Use the other bundle handlers, once
      //   https://www.drupal.org/node/2322949 is in.
      $views_field['filter']['id'] = 'bundle';
    }

Do you think we can simply drop them now?

Raising to critical, because this looks like it's in the first (necessary for access control) category of the "proposed resolution" of #2393339: [META] Make sure Views base fields are using Field API for formatting, and do not lose functionality, but please correct me if I'm mistaken.

Went through the views and these are indeed the only adjustments you have to do

+++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_entity_type_filter.yml
@@ -75,9 +75,23 @@ display:
diff --git a/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml

diff --git a/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml
index 32b0692..d73c2ef 100644

index 32b0692..d73c2ef 100644
--- a/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml

--- a/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml
+++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml

+++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml
+++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_exposed_admin_ui.yml
@@ -31,7 +31,6 @@ display:

@@ -31,7 +31,6 @@ display:
           field: type
           id: type
           table: node_field_data
-          plugin_id: node_type
           entity_type: node
           entity_field: type
         body_value:

This is a change on a filter, let's drop that change, even it might be technically the right thing to do.

Yep, agreed. Here you go.

Thank you!

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 5c2ec02 and pushed to 8.0.x. Thanks!

#2462589: Provide test coverage for access checking of all views fields. will provide the necessary access tests.