Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2015 at 12:37 UTC
Updated:
5 Jun 2015 at 16:25 UTC
Jump to comment: Most recent
Comments
Comment #1
dk129 commentedComment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdk1292418459git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
dk129 commentedJust updated the code to follow coding standards suggested by pareview.sh
Comment #4
crstnkal commentedHello,
I notice some things about your module:
Comment #5
crstnkal commentedComment #6
dk129 commentedThanks Christina,
I just put in hook_uninstall implementation and remove ref.api.php
Comment #7
franksj commentedFirstly, your project application doesn't follow the prescribed format. Include your git information in this issue so we don't have to fill it in ourselves.
Manual Review
Here is a summary of the preferred format:
===/---to the length of the heading, followed by a newline.This review uses the Project Application Review Template.
What does this module give us that entity reference or relation don't give us? I'm not entirely sure what this module is meant to do. The sample code doesn't really provide a lot of insight. I create a couple of nodes, run the sample code, tweak it a little so that maybe I can do something with both of my Article nodes, and it doesn't seem to be giving me anything. Using an entity reference field, I can create a reference from one node or entity to another node or entity. I am not sure this meets the Duplication criteria.
Comment #8
dk129 commentedThanks for your review,
Although the intent is to make ref as an API module, I agree that it will be much more transparency for user to see how it really works and how it differs from the other two (relation + entityreference), thus I will make an UI module for ref.
Will give an update on this shortly.
Comment #9
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.