Module name: ref
Description: API module for creating relationship between entities. Relationship data are saved schema-less. Data structure is key - value with key is a dot-notation string.
Sandbox project: https://www.drupal.org/sandbox/dk129/2418459
Drupal core version: 7.x

Comments

dk129’s picture

Status: Active » Needs review
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdk1292418459git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

dk129’s picture

Status: Needs work » Needs review

Just updated the code to follow coding standards suggested by pareview.sh

crstnkal’s picture

Hello,
I notice some things about your module:

  • There is no hook_uninstall implementation in your .install file.
  • I didn't find any custom hooks in your module in order to have a ref.api.php file.
crstnkal’s picture

Status: Needs review » Needs work
dk129’s picture

Status: Needs work » Needs review

Thanks Christina,

I just put in hook_uninstall implementation and remove ref.api.php

franksj’s picture

Status: Needs review » Needs work

Firstly, your project application doesn't follow the prescribed format. Include your git information in this issue so we don't have to fill it in ourselves.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
No: Causes module duplication and/or fragmentation. What differentiates this module from Relation or Entity Reference?
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Followsthe licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. The README.md file does not remotely follow an accepted template. You are missing the overview, the installation section, the requirements section, the configuration section, and the format is completely off.
Here is a summary of the preferred format:
  • Headings in all caps.
  • Headings underlined with ===/--- to the length of the heading, followed by a newline.
  • Two lines prior to headings (except the first one).
  • Bullets denoted by asterisks (*) with hanging indents.
  • Numbered lists indented 4 spaces.
  • Bulleted lists indented 1 space.
  • Text manually word-wrapped within around 80 cols.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
pareview says you have an unused variable on line 107.
List of identified issues in no particular order.
  1. (*) Function ref() on line 122 doesn't follow the module function naming scheme. ref_init() perhaps?

This review uses the Project Application Review Template.

What does this module give us that entity reference or relation don't give us? I'm not entirely sure what this module is meant to do. The sample code doesn't really provide a lot of insight. I create a couple of nodes, run the sample code, tweak it a little so that maybe I can do something with both of my Article nodes, and it doesn't seem to be giving me anything. Using an entity reference field, I can create a reference from one node or entity to another node or entity. I am not sure this meets the Duplication criteria.

dk129’s picture

Thanks for your review,

Although the intent is to make ref as an API module, I agree that it will be much more transparency for user to see how it really works and how it differs from the other two (relation + entityreference), thus I will make an UI module for ref.

Will give an update on this shortly.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.