sweetCaptcha is a fresh, friendly, action-based CAPTCHA service that’s easy for you to add to your website
and less frustrating for users to solve than difficult-to-decipher text-based CAPTCHA

http://sweetcaptcha.com/

Sandbox url https://www.drupal.org/sandbox/yogen.prasad/2420543

Automated Review :
http://pareview.sh/pareview/httpgitdrupalorgsandboxyogenprasad2420543git

CommentFileSizeAuthor
#1 sweetcaptcha.zip60.3 KByogen.prasad

Comments

yogen.prasad’s picture

yogen.prasad commented
StatusFileSize
new sweetcaptcha.zip60.3 KB
yogen.prasad’s picture

yogen.prasad commented
Status: Needs work » Needs review

Please review it.

shamsher_alam’s picture

shamsher_alam commented

Need some reviews.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: Unassigned » naveenvalecha
Issue summary: View changes
Issue tags: +PAreview: single application approval

Automated Review :
http://pareview.sh/pareview/httpgitdrupalorgsandboxyogenprasad2420543git
Need to fix all these.
Assigned to myself for next review that may be tonight.Assuming all the above issues will be addressed before reviewing by me.
Added PAReview: Single project promote tag.
As all reviewers are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to ""needs work"" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

PA robot’s picture

PA robot commented
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2445663

Project 2: https://www.drupal.org/node/2339289

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

yogen.prasad’s picture

yogen.prasad commented
Status: Needs review » Reviewed & tested by the community

Thanks for instant feedback and i am working on issues.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Needs review

Module author can't make his issue to RTBC.See the project application workflow https://www.drupal.org/node/532400
Please add comment after doing the changes.

shamsher_alam’s picture

shamsher_alam commented
Status: Needs review » Reviewed & tested by the community

Working Fine.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: naveenvalecha » Unassigned
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
Issue tags: -PAreview: single application approval +PAreview: security

Automated Review

Need to fix Best practice issues identified by pareview.sh / drupalcs / coder.http://pareview.sh/pareview/httpgitdrupalorgsandboxyogenprasad2420543git Please fix all those.

Manual Review : Read d14fe75...

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not causemodule duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
No: Meets the security requirements.
  • (+) sweetcaptcha_form_alter : $sweetcapcha_output = $sweetcapcha->get_html(); This data is coming from sweetcaptcha 3rd party service so you need to sanitize it before printing.See http://drupal.stackexchange.com/questions/10280/is-check-plain-enough
    • Coding style & Drupal API usage
    1. Project page needs updation.See the tips https://www.drupal.org/node/997024
    2. (+) The module has 2 authors let us know which of you want the git vetted role.Please add a comment.
    3. Add a hook_requirements and made the sweetcaptcha as library. and remove the include_once statement from the module file.

    4. Error message

      • Warning: include_once(/sweetcaptcha.php) [function.include-once]: failed to open stream: No such file or directory in include_once() (line 7 of /Applications/MAMP/htdocs/d7.dev/sites/all/modules/sandbox/sweetcaptcha/sweetcaptcha.module).
      • Warning: include_once() [function.include]: Failed opening '/sweetcaptcha.php' for inclusion (include_path='.:/Applications/MAMP/bin/php/php5.3.29/lib/php') in include_once() (line 7 of /Applications/MAMP/htdocs/d7.dev/sites/all/modules/sandbox/sweetcaptcha/sweetcaptcha.module).
      • Warning: include_once(/sweetcaptcha.php) [function.include-once]: failed to open stream: No such file or directory in include_once() (line 7 of /Applications/MAMP/htdocs/d7.dev/sites/all/modules/sandbox/sweetcaptcha/sweetcaptcha.module).
      • Warning: include_once() [function.include]: Failed opening '/sweetcaptcha.php' for inclusion (include_path='.:/Applications/MAMP/bin/php/php5.3.29/lib/php') in include_once() (line 7 of /Applications/MAMP/htdocs/d7.dev/sites/all/modules/sandbox/sweetcaptcha/sweetcaptcha.module).
    5. sweetcaptcha_form_alter : $form['#validate'][] = "sweetcaptcha_form_submit";Use #submit instead of #validate.
    6. sweetcaptcha_form_submit : Use single quotes instead of double quotes as per durpal coding standards.it will also give some performance hits as well
    7. (*)sweetcaptcha_form_submit : Use $form_state['values'] instead of $form_state['input']
    8. hook_help is missing in module.It would be nice to include it.

    The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

    If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

    This review uses the Project Application Review Template.

    kaustubhb’s picture

    kaustubhb commented
    Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

    working good..!!

    naveenvalecha’s picture

    naveenvalecha
    He/Him
    commented

    @kaustubhb,
    Have the above issues specified in #9 has been addressed ? Is not there anything you found any blocker ? Please add a comment.

    kaustubhb’s picture

    kaustubhb commented

    @naveenvalecha I did not see any blocker issue and Module is working fine.

    naveenvalecha’s picture

    naveenvalecha
    He/Him
    commented
    Status: Reviewed & tested by the community » Needs work

    @kaustubhb,
    great! I would encourage you to use Project Application Review template to do the reviews it will cover all the things for you.
    Read latest d14fe75...I have seen that #9 has not been addresssed so moving to needs work.

    klausi’s picture

    klausi
    he/him||they/them
    Primary language German
    Location 🇦🇹 Vienna
    commented

    https://www.drupal.org/project/sweetcaptcha

    This sounds like a feature that should live in the existing sweetcaptcha project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the sweetcaptcha issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

    If that fails for whatever reason please get back to us and set this back to "needs review".

    Once the code is in the existing sweetcaptcha repository we can continue reviewing here.

    yogen.prasad’s picture

    yogen.prasad commented

    @klausi

    We have started a issue thread with the existing Sweetcaptcha maintainer . It seems that he had deleted the code with a request to delete the node and the project and is no longer available on https://www.drupal.org/project/sweetcaptcha.

    So i think we can continue working on this sandbox project, just waiting for a response on the issue : https://www.drupal.org/node/2450225

    Thanks

    yogen.prasad’s picture

    yogen.prasad commented
    Status: Needs work » Closed (won't fix)

    Got the access for the https://www.drupal.org/project/sweetcaptcha..

    can close the issue now.

    Thanks