One-time approval process application.

1. Project Name: Views Pipes

2. Description (from project page):
Views pipes lets Views Administrators use output from a field in the rows of one view (the output view) as contextual filter arguments for another view (the input view).

A case for using the module might be when a site developer needs to exclude the results of one view from another view.

For example, to create a view showing all users who have not authored an article (which is not easy, dare it be said impossible, using Views), do the following:

  1. Add a view to show all users - this will be the input view.
  2. In the contextual filter settings of this view add a uid filter. Ensure that it can accept multiple values and that they are excluded - these settings can be found by expanding the collapsible fieldset labeled 'More' at the bottom of the contextual filter settings.
  3. Add a view showing all users authoring articles. Important: it must be a table. This is the output view.
  4. Add a uid field to this view. This provides the output.
  5. In the Views Pipes overview page add a new Views Pipe.
  6. Give it a name, ensure it is enabled, use the select boxs to drill down to the output field and the input argument from the two views and then save.
  7. Display the input view. Users who have created articles should no longer be there.

3. Project page link:
https://www.drupal.org/sandbox/knoboid/2429901

4. Git Clone:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/knoboid/2429901.git views_pipes

5. No reviews of other projects to date.

Comments

PA robot’s picture

PA robot commented
Status: Active » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxknoboid2429901git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

knoboid’s picture

knoboid commented
Issue summary: View changes
knoboid’s picture

knoboid commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

knoboid’s picture

knoboid commented
Status: Closed (won't fix) » Needs review
knoboid’s picture

knoboid commented
Title: Views Pipes » [D7] Views Pipes
npacker’s picture

npacker commented

Great idea for a module.

I'm getting an error after following the setup instructions:

Warning: array_keys() expects parameter 1 to be array, null given in array_keys() (line 109 of /var/www/sites/drupal/sites/all/modules/views_pipes/views_pipes.module). =>

knoboid’s picture

knoboid commented

Thank you for your time.

Embarrassing, but I dropped an important return statement when I was getting the code to comply with coding standards.

Hopefully working for you now.

PA robot’s picture

PA robot commented
Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

yonko.tsvetkov’s picture

yonko.tsvetkov commented

Hi knoboid,

I tested Views Pipes module.

Pareview shows only warnings:

http://pareview.sh/pareview/httpgitdrupalorgsandboxknoboid2429901git

After Manual Review:

1. Your views_pipes.info has to be changed. Regarding https://www.drupal.org/node/542202 ,
Please re-order rows: core = 7.x, dependencies[] = views and package = Views

2. README.txt has to be changed. Please see https://www.drupal.org/node/2181737 for more info.

knoboid’s picture

knoboid commented
Status: Needs review » Needs work
knoboid’s picture

knoboid commented
Status: Needs work » Needs review

Thanks for the review Yonko.

I've seen to all the points raised.

npacker’s picture

npacker commented

I'm back.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
1. The field descriptions in hook_schema() should probably be filled in. Currently they are all TODO.

knoboid’s picture

knoboid commented
Status: Needs review » Needs work
PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.