Loads of development has been going on in Panelizer, including patches that we've contributed. But we're still working off the current stable releases plus patches - it'd be great to try out the latest -dev code and help push it to release!

TODO

  1. Update the panopoly_pages feature and see if there are changes
  2. Update the panopoly_test feature and see if there are changes
  3. Fix Panopoly issue #2513996: Hide display of fields on all view modes that are panelized
  4. Fix Panelizer issue #2514068: Error editing user Panelizer content with revisions
CommentFileSizeAuthor
#50 panopoly_core-update-panelizer-2429549-50.patch9.88 KBdsnopek
#49 panopoly_pages-update-panelizer-2429549-49.patch15.18 KBdsnopek
#49 panopoly_users-update-panelizer-2429549-49.patch9.92 KBdsnopek
#49 panopoly_core-update-panelizer-2429549-49.patch10.34 KBdsnopek
#47 panopoly-n2429549-47.patch9.86 KBDamienMcKenna
#46 panopoly-n2429549-46.patch1.41 KBDamienMcKenna
#40 panopoly-n2429549-40.patch1.55 KBDamienMcKenna
#38 panopoly-n2429549-38.patch1018 bytesDamienMcKenna
#35 2429549-panopoly_core-update-latest-dev-of-panelizer-35.patch1.14 KBHaiNguyen007
#34 2429549-panopoly_core-update-latest-dev-of-panelizer-34.patch1.25 KBHaiNguyen007
#32 2429549-panopoly_core-panelizer-32.patch1.33 KBhefox
#31 2429549-panelizer-31.patch1.22 KBhefox
#30 2429549-panopoly_core-update-latest-panelizer-30.patch1.23 KBmpotter
#3 2429549-use-latest-dev-of-panelizer.patch939 bytesHaiNguyen007
#6 update_to_latest-2429549-6.patch874 bytesmglaman
#8 update_to_latest-2429549-8.patch914 bytesmglaman
#9 panopoly_core-update_to_latest-2429549-9.patch2.88 KBmglaman
#10 panopoly_users-update_to_latest-2429549-10.patch1.86 KBmglaman
#12 2429549-2483265-panopoly_core-update-panelizer-and-fieldable_panels_panes-to-latest-dev.patch4.14 KBHaiNguyen007
#12 2429549-2483265-panopoly_users-update-panelizer-and-fieldable_panels_panes-to-latest-dev.patch1.98 KBHaiNguyen007
#12 2429549-2483265-panopoly_magic-update-panelizer-and-fieldable_panels_panes-to-latest-dev.patch815 bytesHaiNguyen007
#16 Hide patch.png16.52 KBHaiNguyen007
#18 2499549-panopoly_core-update-latest-dev-of-panelizer-and-fieldable-panels-panes-18.patch2.21 KBHaiNguyen007
#20 2429549-panopoly_core-update-latest-panelizer-20.patch1.11 KBmpotter
#21 panopoly_core-update-panelizer-2429549-21.patch2.88 KBdsnopek
#24 panopoly_core-update-panelizer-2429549-24-do-not-test.patch2.99 KBhefox
#25 2499549-panopoly_core-update-latest-dev-of-panelizer-25.patch1.11 KBHaiNguyen007
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek’s picture

I'm debating whether this should be two seperate issues... If one of these modules is in better shape than the other, we might get this in quicker. FYI, I've just started testing the latest Panelizer -dev and things are looking mostly good! I RTBC'd #2445769: Unable to clone a display for Damien McKenna.

dsnopek’s picture

Issue tags: +sprint
HaiNguyen007’s picture

Patch panopoly_core for personal use:
For using latest dev of panelizer for my personal panopoly-based distro.

dsnopek’s picture

Title: Update to FPP 1.6-beta1 and Panelizer 3.2-beta1 » Update to latest Panelizer
Issue summary: View changes
Related issues: +#2483265: Update to latest Fieldable Panels Panes (FPP)

I'm going to make this issue just about Panelizer, so we can work on it seperately from FPP which I created a new issue for:

#2483265: Update to latest Fieldable Panels Panes (FPP)

dsnopek’s picture

Status: Active » Needs work

@HaiNguyen007: Thanks for the patch!

  1. +++ b/panopoly_core.make
    @@ -15,10 +15,10 @@ projects[panels][patch][2448825] = https://www.drupal.org/files/issues/panels-ex
    +projects[panelizer][download][url] = git://git.drupal.org/project/panelizer.git
    

    It isn't necessary to specify this for a Git repo on Drupal.org. You can just omit this line.

  2. +++ b/panopoly_core.make
    @@ -15,10 +15,10 @@ projects[panels][patch][2448825] = https://www.drupal.org/files/issues/panels-ex
    +projects[panelizer][download][revision] = cbc19ad09e683b06a817a920228be5a0e8595143
    

    We only put the first 7 characters of Git revision hashes in our .make files. Can you please remove the extra characters!

    Also, please specify projects[panelizer][download][branch] too. Thanks!

I've started a run on Travis to how it does with our automated tests:

https://travis-ci.org/panopoly/panopoly/builds/61310443

mglaman’s picture

Status: Needs work » Needs review
FileSize
874 bytes

Rerolled with comments from #5 and bumped revision to include some fixes from past few days.

dsnopek’s picture

Status: Needs review » Needs work

@mglaman: Thanks!

+++ b/panopoly_core.make
@@ -15,10 +15,10 @@ projects[panels][patch][2448825] = https://www.drupal.org/files/issues/panels-ex
-projects[panelizer][version] = 3.1

One thing I didn't notice before: we usually set the version to something like "3.x-dev". I'm actually not sure if that's necessary or even does anything, but we do it everywhere else, so I'd like to here as well for consistency.

mglaman’s picture

Status: Needs work » Needs review
FileSize
914 bytes

Version adjusted

mglaman’s picture

Here is (another) updated Panopoly Core patch to fix override.

mglaman’s picture

And Panopoly Users patch to fix overridden.

dsnopek’s picture

Sweet, thanks! I kicked off a new build on Travis with the new patches:

https://travis-ci.org/panopoly/panopoly/builds/61358165

dsnopek’s picture

@HaiNguyen007: Thanks for your enthusiasm! :-) However, in the future, please mark patches as 'hidden' if they aren't intended to be committed - it makes it difficult to for people to see which patches they should be testing and reviewing and could slow down our progress in getting it committed.

dsnopek’s picture

Here's a new Travis build with the latest patches, but this time running the upgrade tests:

https://travis-ci.org/panopoly/panopoly/builds/63026196

Since this appears to be working, I'm not sure what the criteria for commit should be... Ideally, we wouldn't release on a -dev version, but what can we do to help get the next Panelizer release out?

HaiNguyen007’s picture

Thanks @dsnopek for guide: "However, in the future, please mark patches as 'hidden' if they aren't intended to be committed - it makes it difficult to for people to see which patches they should be testing and reviewing and could slow down our progress in getting it committed." The first time I know how to make a patch hidden :D. I will follow that practice from now.

HaiNguyen007’s picture

FileSize
16.52 KB

@dsnopek: beginner question: I untick "Display" for hiding patch is correct or not?

HaiNguyen007’s picture

HaiNguyen007’s picture

dsnopek’s picture

beginner question: I untick "Display" for hiding patch is correct or not?

Yep, that's correct!

mpotter’s picture

Here is an updated patch for the latest Panopoly dev (and v1.22). It removes the fieldable_panels_pane patches since we are using the 1.6 release now. Also updates panelizer to their latest dev revision. Also fixes the issue number in the patch filename.

dsnopek’s picture

@mpotter: Thanks! However, you're patch is missing critical other changes from the patch on #9, which is the last real patch for panopoly_core -- the ones from HaiNguyen007 were just for his own personal use in his .make files. I tried to make that clear by asking him to hide them, but maybe in the future I'll ask people to create seperate issues for that purpose.

Here is a re-roll of the patch from #9, updated to the last revision hash!

Note: both the patches (for panopoly_core and panopoly_user) are required for the tests to pass (or they did pass, back in #11

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/65586645

dsnopek’s picture

dsnopek’s picture

Issue summary: View changes
Status: Needs review » Needs work

It just occurred to me that if panopoly_core and panopoly_users need a drush fu then maybe we should see if panopoly_pages and panopoly_test (which both define content types using Panelizer) need to be updated too! Added a TODO to the issue summary. It's possible no changes are needed, but we should be sure to check it out...

hefox’s picture

Marked this one as do not test so not to sidereal the current testing/patch; this is #21 with added patch for #1549608: Cannot import exported Panelizer permissions using Features/defaultconfig if handler cache is stale, but the method I used for this patch is questionable so need to see what other's think.

HaiNguyen007’s picture

dsnopek’s picture

We should fix this issue before updating to the latest Panelizer:

#2513996: Hide display of fields on all view modes that are panelized

dsnopek’s picture

Issue summary: View changes

Added to the TODO in the issue summary as well.

mpotter’s picture

Been using latest -dev of Panelizer in Open Atrium with Panopoly 1.23. We ran into an issue with Panelizer not working on User entities when revisioning is enabled. Posted this issue to Panelizer #2514068: Error editing user Panelizer content with revisions. Will need to keep track of this issue for Panopoly as well.

dsnopek’s picture

mpotter’s picture

Here is the latest consolidated patch being used in Open Atrium that includes #28.

hefox’s picture

dsnopek’s picture

HaiNguyen007’s picture

Update panelizer & uuid to latest code (working for me)

HaiNguyen007’s picture

above patch is error, this patch fix

dsnopek’s picture

We have a separate issue for updating to the -beta of UUID: #2597275: Update UUID to version 1.1

This patch should focus only on updating Panelizer with the current version of UUID, there's a separate set of issues concerns for UUID that need to be worked out. Tying them together will just slow this down.

HaiNguyen007’s picture

Thank you for clarify

DamienMcKenna’s picture

Status: Postponed » Needs review
FileSize
1018 bytes

Updated to the latest Panelizer. This doesn't include the UUID patch, but it does add the fix-Features patch from hefox because I haven't gotten around to testing that stuff yet.

dsnopek’s picture

Here's a test build on Travis of the latest patch:

https://travis-ci.org/panopoly/panopoly/jobs/141067636

DamienMcKenna’s picture

FileSize
1.55 KB

Might this fix it?

dsnopek’s picture

What goes in that variable? Maybe we want it in the Feature? We definitely Panelize that taxonomy vocabulary...

dsnopek’s picture

Here's an updated build anyway, just to see what happens:

https://travis-ci.org/panopoly/panopoly/jobs/141119998

DamienMcKenna’s picture

Ran into problems running the tests locally :-\

dsnopek’s picture

That last build on Travis passed! At this point, it's just a question for me if we should really be excluding that variable, or if we should instead be putting it into the Feature per my question in #41

DamienMcKenna’s picture

Status: Needs review » Needs work

3.2 is out, so this needs to be updated again.

DamienMcKenna’s picture

DamienMcKenna’s picture

FileSize
9.86 KB

I installed Panelizer 3.2, ran the db updates, cleared all caches, saved the main Panelizer settings page and then exported the panopoly_core feature. This is the results.

dsnopek’s picture

Thanks, Damien! That looks great. :-) I'm running the tests on Travis again:

https://travis-ci.org/panopoly/panopoly/builds/142441844

We should probably also take this opportunity to rebuild the panopoly_pages and panopoly_users features as well, since they both include Panelizer configurations. I expect the changes to be equally simple! I'll try to get to this later if no one beats me to it.

dsnopek’s picture

The last patch didn't pass. :-(

Here's an attempt to fix that, and also regenerate the features for panopoly_pages and panopoly_users!

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/153003630

dsnopek’s picture

FileSize
9.88 KB

Ah, that build is going to fail because we moved the 'taxonomy' dependency in panopoly_core. I'm so glad we added that test, because we would have just broken all child distributions!

Here's a new patch.

EDIT: Here's the build on Travis: https://travis-ci.org/panopoly/panopoly/builds/153005570

dsnopek’s picture

The previous test failures are gone! There was a failure, but it looks like a gremlin - I'm re-running the job to be sure.

chrisgross’s picture

Panelizer 3.3 is out, per SA-CONTRIB-2016-048. I was going to make a patch, but I wasn't sure if your latest patch here would be affected.

chrisgross’s picture

Looks like it is required to also update Panels to 3.6. Should this be a separate issue or can we take care of all of that here?

  • dsnopek committed d41dfd5 on 7.x-1.x
    Update Panopoly Core, Users and Pages for Issue #2429549 by HaiNguyen007...
dsnopek’s picture

@chrisgross: I'm going to do the Panels and Panelizer update as part of a follow-up issue, I'll make it in a moment

dsnopek’s picture

Status: Needs review » Fixed

Tests finally passed! Committed :-)

dsnopek’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.