Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Loads of development has been going on in Panelizer, including patches that we've contributed. But we're still working off the current stable releases plus patches - it'd be great to try out the latest -dev code and help push it to release!
TODO
- Update the panopoly_pages feature and see if there are changes
- Update the panopoly_test feature and see if there are changes
- Fix Panopoly issue #2513996: Hide display of fields on all view modes that are panelized
- Fix Panelizer issue #2514068: Error editing user Panelizer content with revisions
Comment | File | Size | Author |
---|---|---|---|
#50 | panopoly_core-update-panelizer-2429549-50.patch | 9.88 KB | dsnopek |
#49 | panopoly_pages-update-panelizer-2429549-49.patch | 15.18 KB | dsnopek |
#49 | panopoly_users-update-panelizer-2429549-49.patch | 9.92 KB | dsnopek |
Comments
Comment #1
dsnopekI'm debating whether this should be two seperate issues... If one of these modules is in better shape than the other, we might get this in quicker. FYI, I've just started testing the latest Panelizer -dev and things are looking mostly good! I RTBC'd #2445769: Unable to clone a display for Damien McKenna.
Comment #2
dsnopekComment #3
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedPatch panopoly_core for personal use:
For using latest dev of panelizer for my personal panopoly-based distro.
Comment #4
dsnopekI'm going to make this issue just about Panelizer, so we can work on it seperately from FPP which I created a new issue for:
#2483265: Update to latest Fieldable Panels Panes (FPP)
Comment #5
dsnopek@HaiNguyen007: Thanks for the patch!
It isn't necessary to specify this for a Git repo on Drupal.org. You can just omit this line.
We only put the first 7 characters of Git revision hashes in our .make files. Can you please remove the extra characters!
Also, please specify
projects[panelizer][download][branch]
too. Thanks!I've started a run on Travis to how it does with our automated tests:
https://travis-ci.org/panopoly/panopoly/builds/61310443
Comment #6
mglamanRerolled with comments from #5 and bumped revision to include some fixes from past few days.
Comment #7
dsnopek@mglaman: Thanks!
One thing I didn't notice before: we usually set the version to something like "3.x-dev". I'm actually not sure if that's necessary or even does anything, but we do it everywhere else, so I'd like to here as well for consistency.
Comment #8
mglamanVersion adjusted
Comment #9
mglamanHere is (another) updated Panopoly Core patch to fix override.
Comment #10
mglamanAnd Panopoly Users patch to fix overridden.
Comment #11
dsnopekSweet, thanks! I kicked off a new build on Travis with the new patches:
https://travis-ci.org/panopoly/panopoly/builds/61358165
Comment #12
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedI combine both patch in Update to latest Panelizer & Update to latest Fieldable Panels Panes (FPP) for panopoly-1.21 (for personal use & maybe benefit others); I'm tested all things work well so far.
Comment #13
dsnopek@HaiNguyen007: Thanks for your enthusiasm! :-) However, in the future, please mark patches as 'hidden' if they aren't intended to be committed - it makes it difficult to for people to see which patches they should be testing and reviewing and could slow down our progress in getting it committed.
Comment #14
dsnopekHere's a new Travis build with the latest patches, but this time running the upgrade tests:
https://travis-ci.org/panopoly/panopoly/builds/63026196
Since this appears to be working, I'm not sure what the criteria for commit should be... Ideally, we wouldn't release on a -dev version, but what can we do to help get the next Panelizer release out?
Comment #15
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedThanks @dsnopek for guide: "However, in the future, please mark patches as 'hidden' if they aren't intended to be committed - it makes it difficult to for people to see which patches they should be testing and reviewing and could slow down our progress in getting it committed." The first time I know how to make a patch hidden :D. I will follow that practice from now.
Comment #16
HaiNguyen007 CreditAttribution: HaiNguyen007 commented@dsnopek: beginner question: I untick "Display" for hiding patch is correct or not?
Comment #17
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedComment #18
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedPatch for personal use only
Comment #19
dsnopekYep, that's correct!
Comment #20
mpotter CreditAttribution: mpotter commentedHere is an updated patch for the latest Panopoly dev (and v1.22). It removes the fieldable_panels_pane patches since we are using the 1.6 release now. Also updates panelizer to their latest dev revision. Also fixes the issue number in the patch filename.
Comment #21
dsnopek@mpotter: Thanks! However, you're patch is missing critical other changes from the patch on #9, which is the last real patch for panopoly_core -- the ones from HaiNguyen007 were just for his own personal use in his .make files. I tried to make that clear by asking him to hide them, but maybe in the future I'll ask people to create seperate issues for that purpose.
Here is a re-roll of the patch from #9, updated to the last revision hash!
Note: both the patches (for panopoly_core and panopoly_user) are required for the tests to pass (or they did pass, back in #11
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/65586645
Comment #22
dsnopekComment #23
dsnopekIt just occurred to me that if panopoly_core and panopoly_users need a
drush fu
then maybe we should see if panopoly_pages and panopoly_test (which both define content types using Panelizer) need to be updated too! Added a TODO to the issue summary. It's possible no changes are needed, but we should be sure to check it out...Comment #24
hefox CreditAttribution: hefox at Phase2 commentedMarked this one as do not test so not to sidereal the current testing/patch; this is #21 with added patch for #1549608: Cannot import exported Panelizer permissions using Features/defaultconfig if handler cache is stale, but the method I used for this patch is questionable so need to see what other's think.
Comment #25
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedComment #26
dsnopekWe should fix this issue before updating to the latest Panelizer:
#2513996: Hide display of fields on all view modes that are panelized
Comment #27
dsnopekAdded to the TODO in the issue summary as well.
Comment #28
mpotter CreditAttribution: mpotter commentedBeen using latest -dev of Panelizer in Open Atrium with Panopoly 1.23. We ran into an issue with Panelizer not working on User entities when revisioning is enabled. Posted this issue to Panelizer #2514068: Error editing user Panelizer content with revisions. Will need to keep track of this issue for Panopoly as well.
Comment #29
dsnopekThanks, @mpotter!
I put that in the issue summary, and I'm going to mark this issue as postponed on:
#2513996: Hide display of fields on all view modes that are panelized
#2514068: Error editing user Panelizer content with revisions
Comment #30
mpotter CreditAttribution: mpotter commentedHere is the latest consolidated patch being used in Open Atrium that includes #28.
Comment #31
hefox CreditAttribution: hefox at Phase2 commentedUpdating patch #2514068: Error editing user Panelizer content with revisions
Comment #32
hefox CreditAttribution: hefox at Phase2 commentedAdding #1549608: Cannot import exported Panelizer permissions using Features/defaultconfig if handler cache is stale
Comment #33
dsnopekComment #34
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedUpdate panelizer & uuid to latest code (working for me)
Comment #35
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedabove patch is error, this patch fix
Comment #36
dsnopekWe have a separate issue for updating to the -beta of UUID: #2597275: Update UUID to version 1.1
This patch should focus only on updating Panelizer with the current version of UUID, there's a separate set of issues concerns for UUID that need to be worked out. Tying them together will just slow this down.
Comment #37
HaiNguyen007 CreditAttribution: HaiNguyen007 commentedThank you for clarify
Comment #38
DamienMcKennaUpdated to the latest Panelizer. This doesn't include the UUID patch, but it does add the fix-Features patch from hefox because I haven't gotten around to testing that stuff yet.
Comment #39
dsnopekHere's a test build on Travis of the latest patch:
https://travis-ci.org/panopoly/panopoly/jobs/141067636
Comment #40
DamienMcKennaMight this fix it?
Comment #41
dsnopekWhat goes in that variable? Maybe we want it in the Feature? We definitely Panelize that taxonomy vocabulary...
Comment #42
dsnopekHere's an updated build anyway, just to see what happens:
https://travis-ci.org/panopoly/panopoly/jobs/141119998
Comment #43
DamienMcKennaRan into problems running the tests locally :-\
Comment #44
dsnopekThat last build on Travis passed! At this point, it's just a question for me if we should really be excluding that variable, or if we should instead be putting it into the Feature per my question in #41
Comment #45
DamienMcKenna3.2 is out, so this needs to be updated again.
Comment #46
DamienMcKennaThe patch from #40 updated to Panelizer 3.2.
Comment #47
DamienMcKennaI installed Panelizer 3.2, ran the db updates, cleared all caches, saved the main Panelizer settings page and then exported the panopoly_core feature. This is the results.
Comment #48
dsnopekThanks, Damien! That looks great. :-) I'm running the tests on Travis again:
https://travis-ci.org/panopoly/panopoly/builds/142441844
We should probably also take this opportunity to rebuild the panopoly_pages and panopoly_users features as well, since they both include Panelizer configurations. I expect the changes to be equally simple! I'll try to get to this later if no one beats me to it.
Comment #49
dsnopekThe last patch didn't pass. :-(
Here's an attempt to fix that, and also regenerate the features for panopoly_pages and panopoly_users!
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/153003630
Comment #50
dsnopekAh, that build is going to fail because we moved the 'taxonomy' dependency in panopoly_core. I'm so glad we added that test, because we would have just broken all child distributions!
Here's a new patch.
EDIT: Here's the build on Travis: https://travis-ci.org/panopoly/panopoly/builds/153005570
Comment #51
dsnopekThe previous test failures are gone! There was a failure, but it looks like a gremlin - I'm re-running the job to be sure.
Comment #52
chrisgross CreditAttribution: chrisgross commentedPanelizer 3.3 is out, per SA-CONTRIB-2016-048. I was going to make a patch, but I wasn't sure if your latest patch here would be affected.
Comment #53
chrisgross CreditAttribution: chrisgross commentedLooks like it is required to also update Panels to 3.6. Should this be a separate issue or can we take care of all of that here?
Comment #55
dsnopek@chrisgross: I'm going to do the Panels and Panelizer update as part of a follow-up issue, I'll make it in a moment
Comment #56
dsnopekTests finally passed! Committed :-)
Comment #57
dsnopek@chrisgross: Here's the follow-up issue #2785825: Update Panels and Panelizer for SA-CONTRIB-2016-047 and SA-CONTRIB-2016-048