Loads of development has been going on in Fieldable Panels Panes (FPP), including patches that we've contributed. But we're still working off the current stable releases plus patches - it'd be great to try out the latest -dev code and help push it to release!

Issues to fix

  1. Empty revision fieldset on existing FPPs. It doesn't look terribly useful - we should probably hide it:
CommentFileSizeAuthor
#9 panopoly_magic-update-fpp-2483265-9.patch755 bytesdsnopek
#9 panopoly_test-update-fpp-2483265-9.patch892 bytesdsnopek
#9 panopoly_core-update-fpp-2483265-9.patch1.42 KBdsnopek
#8 panopoly_core-update-fpp-2483265-8.patch1.6 KBdsnopek
#7 panopoly_core-update-fpp-2483265-7.patch1.73 KBdsnopek
#6 panopoly_test-update-fpp-2483265-6.patch892 bytesdsnopek
#3 panopoly_magic-update-fpp-2483265-3.patch755 bytesdsnopek
#2 Selection_079.png3.67 KBdsnopek
#1 panopoly_core-update-fpp-2483265-1.patch1.6 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_core-update-fpp-2483265-1.patch1.6 KB

Attached is a patch to update to the latest -dev as of today! I'm going to run it through Travis in a moment.

EDIT: Here's the build on Travis: https://travis-ci.org/panopoly/panopoly/builds/61310253

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new Selection_079.png3.67 KB

My manual testing has been going really, really well!

I've only found one issue so far: There's an empty revision fieldset on existing FPPs. It doesn't look terribly useful - we should probably hide it:

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new panopoly_magic-update-fpp-2483265-3.patch755 bytes

Here's a panopoly_magic patch that'll hide the revision fieldset.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Related issues: +#2247353: Patch FPP to allow proper UUID subtype on page variant and mini panel export.

The following can be closed once this is committed: #2247353: Patch FPP to allow proper UUID subtype on page variant and mini panel export.

HaiNguyen007’s picture

HaiNguyen007 commented

I combine both patch in Update to latest Panelizer & Update to latest Fieldable Panels Panes (FPP) for panopoly-1.21 (for personal use & maybe benefit others); I'm tested all things work well so far.
Please see 3 patches in: 3 patches for updated panopoly 1.21 to use latest panelizer & fieldable panels panes

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Related issues: +#1911176: Cleanup edit form
StatusFileSize
new panopoly_test-update-fpp-2483265-6.patch892 bytes

The last test build on Travis failed. The cause was changes in the way the edit form worked per #1911176: Cleanup edit form that our tests need to be updated for: basically, the "Make title a link" checkbox won't appear until there is a title, and we were clicking it before setting the title.

Attached is a patch that should fix that failure!

I'll run on Travis again in a moment...

EDIT: Here's the build on Travis-CI: https://travis-ci.org/panopoly/panopoly/builds/63231932

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_core-update-fpp-2483265-7.patch1.73 KB

A new commit was made to FPP, so uploading a new patch so we can run the tests on Travis again.

EDIT: Here is the Travis build: https://travis-ci.org/panopoly/panopoly/builds/63711788

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_core-update-fpp-2483265-8.patch1.6 KB

Updating patch again for the latest commits. I'll run on Travis again in a moment!

EDIT: Here's the build on Travis: https://travis-ci.org/panopoly/panopoly/builds/64000165

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_core-update-fpp-2483265-9.patch1.42 KB
new panopoly_test-update-fpp-2483265-9.patch892 bytes
new panopoly_magic-update-fpp-2483265-9.patch755 bytes

FPP 1.6 was just released:

https://www.drupal.org/node/2497261

Here are re-rolls of all the patches here, which I'm going to run through Travis one last time.

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/64608448

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Tested passed on Travis! Committed. :-)

  • dsnopek committed 9ca0b8a on 7.x-1.x 
    Update Panopoly Core, Magic and Test for Issue #2483265 by dsnopek:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.