Loads of development has been going on in Fieldable Panels Panes (FPP), including patches that we've contributed. But we're still working off the current stable releases plus patches - it'd be great to try out the latest -dev code and help push it to release!

Issues to fix

  1. Empty revision fieldset on existing FPPs. It doesn't look terribly useful - we should probably hide it:
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek’s picture

Status: Active » Needs review
FileSize
1.6 KB

Attached is a patch to update to the latest -dev as of today! I'm going to run it through Travis in a moment.

EDIT: Here's the build on Travis: https://travis-ci.org/panopoly/panopoly/builds/61310253

dsnopek’s picture

Issue summary: View changes
Status: Needs review » Needs work
FileSize
3.67 KB

My manual testing has been going really, really well!

I've only found one issue so far: There's an empty revision fieldset on existing FPPs. It doesn't look terribly useful - we should probably hide it:

dsnopek’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
755 bytes

Here's a panopoly_magic patch that'll hide the revision fieldset.

mglaman’s picture

HaiNguyen007’s picture

I combine both patch in Update to latest Panelizer & Update to latest Fieldable Panels Panes (FPP) for panopoly-1.21 (for personal use & maybe benefit others); I'm tested all things work well so far.
Please see 3 patches in: 3 patches for updated panopoly 1.21 to use latest panelizer & fieldable panels panes

dsnopek’s picture

The last test build on Travis failed. The cause was changes in the way the edit form worked per #1911176: Cleanup edit form that our tests need to be updated for: basically, the "Make title a link" checkbox won't appear until there is a title, and we were clicking it before setting the title.

Attached is a patch that should fix that failure!

I'll run on Travis again in a moment...

EDIT: Here's the build on Travis-CI: https://travis-ci.org/panopoly/panopoly/builds/63231932

dsnopek’s picture

FileSize
1.73 KB

A new commit was made to FPP, so uploading a new patch so we can run the tests on Travis again.

EDIT: Here is the Travis build: https://travis-ci.org/panopoly/panopoly/builds/63711788

dsnopek’s picture

FileSize
1.6 KB

Updating patch again for the latest commits. I'll run on Travis again in a moment!

EDIT: Here's the build on Travis: https://travis-ci.org/panopoly/panopoly/builds/64000165

dsnopek’s picture

FPP 1.6 was just released:

https://www.drupal.org/node/2497261

Here are re-rolls of all the patches here, which I'm going to run through Travis one last time.

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/64608448

dsnopek’s picture

Status: Needs review » Fixed

Tested passed on Travis! Committed. :-)

  • dsnopek committed 9ca0b8a on 7.x-1.x
    Update Panopoly Core, Magic and Test for Issue #2483265 by dsnopek:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.