Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Aug 2016 at 20:21 UTC
Updated:
1 Sep 2016 at 13:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dsnopekPatch is attached! I'll start a build on Travis in a moment.
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/153087240
Comment #3
dsnopekBlergh. Unfortunately, all the tests are failing now. It could be a gremlin but I haven't had a chance to look into it yet.
Comment #4
pieterdcSome changes look like they need more attention than just applying the patch when upgrading Panels in an environment with some custom Panels extensions.
Panels its UPGRADE.txt now states:
panels_renderer_ipe now does access checks.
...
Comment #5
dsnopekOk, I figured out what is going wrong. All the Panels displays that we exported to code don't have the storage_type and storage_id set on them. Here's a patch to panopoly_test just to demonstrate what's going on - got the storage type/id set in the database and then reexported to the Feature. I'll even try with the tests to double check that this is the issue.
Here's a snippet to show:
EDIT: Here's the test build: https://travis-ci.org/panopoly/panopoly/builds/153104500
Comment #6
dsnopekHere's a 2nd attempt at just the panopoly_test changes. This should get more of the tests passing on Travis.
Comment #7
bkosborne^ the problem you described is a major problem for anyone who has panels defined on code, beyond what Panopoly provides =/. Someone else ran into it here: https://www.drupal.org/node/2785915
Comment #8
dsnopekHere's a new panopoly_core patch that also fixes the storage type/id on the panels in that Feature, and includes a Panelizer patch that improves the update hook: #2785883: Infinite loop in panelizer_update_7303
EDIT: Here's a new Travis build: https://travis-ci.org/panopoly/panopoly/builds/153151355
Comment #9
dsnopekHere's patches for panopoly_users and panopoly_pages. There's more to come for the modules that only do Page Manager, and not Panelizer!
Comment #10
dsnopekAnd here's the last round of patches.
EDIT: Here's a test build with all the patches: https://travis-ci.org/panopoly/panopoly/builds/153155022
Comment #11
dsnopekHere's a new panopoly_core patch that integrates the backcompat changes from these Panels and Panelizer patches:
#2785915: Panels permissions update causes access denied on page manager pages defined in code
#2785945: Access denied when editing a Panelizer default that comes from code
EDIT: Here's the test build on Travis: https://travis-ci.org/panopoly/panopoly/builds/153163287
Comment #12
dsnopekUpdate to the latest version of the Panels patch in #2785915: Panels permissions update causes access denied on page manager pages defined in code
EDIT: Here's the test build on Travis: https://travis-ci.org/panopoly/panopoly/builds/153245452
Comment #14
dsnopekTests are passing on the patches, so I committed! I may still need to update again depending on what happens on the Panels and Panelizer issues, but this definitely appears to work for us, so I'd like to move closer to an actual release
EDIT: Here's the Travis build for the committed changes https://travis-ci.org/panopoly/panopoly/builds/153267069