Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When user manually changed classes for media image button "Disable richtext editor" becomes non working with errors to console
Uncaught TypeError: Cannot read property 'value' of undefined
in line 266 of wysiwyg-media.js
This code will work
<img class="media-image img__fid__15731 img__view_mode__media_large attr__format__media_large" src="">
This, not
<img class="media-image src="">
Uploading a patch that fixes this.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | attribution.png | 64.75 KB | podarok |
| media_fix.patch | 658 bytes | podarok | |
Comments
Comment #1
podarokComment #2
jwilson3This patch works as expected and actually resolves some very confounding issues we were experiencing developing media module integration with with CkEditor Image2 plugin, where captions were getting stripped out when the node was being saved.
Comment #4
aaron CreditAttribution: aaron commentedCommitted to http://drupalcode.org/project/media.git/commit/480bdb8.
Comment #5
podarok@aaron - It would be nice to set git credits for the user, that actually fixed an issue.
There is a helpful window already provided within every issue at the bottom.
Thanks.
Comment #6
jwilson3fyi, Git commit message says: "Issue #2428005 by podarok:"
What more did you want?
Comment #7
RedEight CreditAttribution: RedEight commentedI believe podarok is refering to http://cgit.drupalcode.org/media/commit/?id=480bdb8 having author set as "Unknown" rather than him.
Comment #8
Dave Reid@podarok: Hopefully you can excuse someone who was in his last weeks of life, suffering from ALS from properly attributing in Git: https://www.drupal.org/node/2444367
Comment #9
podarokEDIT. Heh. I'm sorry then. My condolences