Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
There appear to be a couple of typos in the webform_handler_filter_submission_data class in the definition of the less than
operator.
Proposed resolution
Fix the typos.
Remaining tasks
Review and test.
User interface changes
None.
API changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2412575-1-typos-in-less-than-operator.patch | 988 bytes | solotandem |
Comments
Comment #1
solotandem CreditAttribution: solotandem commentedAttached patch implements proposed resolution.
Comment #3
DanChadwick CreditAttribution: DanChadwick commentedThanks for the excellent report and patch. Committed to 7.x-4.x and 8.x.
This is more than a typo -- the operator used was wrong, so it was functionally wrong too.
One tiny, tiny request for the future: use the patch file name and commit message Drupal conventions. It makes it a little easier for me and you get credit in the commit log. For reference: Advanced patch contributors guide
Comment #4
DanChadwick CreditAttribution: DanChadwick commentedComment #5
solotandem CreditAttribution: solotandem commentedI agree the operator used was wrong, so it was functionally wrong too. Also guessing noone had used this operator or noticed it did not work as expected based on absence of reported issue, so it was kind of just a typo until then. Thanks.
BTW, the aliased link is not working ATM; do you know if that is a problem with D.O.? The node/nid path works.
Comment #6
DanChadwick CreditAttribution: DanChadwick commentedMy error. I created the link backwards. Fixed now in #3. Sorry.
Yes, I suspect this code was written as part of a huge amount of code to implement views support, and this permutation was never tested, nor was ever used by any of the 500,000+ webform installations. Sucks to be a pioneer, doesn't it?
Comment #8
DanChadwick CreditAttribution: DanChadwick commented