[D7] Node page view 404

Hi,

I would like to suggest you that you fix below mentioned points

Info file
1. Miss spelled word, change "taxonomies" to "taxonomy".
2. Line length must not exceed 80 characters.

Install file
1. Remove all the blank lines from the file.
2. Line length must not exceed 80 characters.

Module file
1. Line length must not exceed 80 characters.
2. Remove unused variables from the code.
3. Remove all the blank lines from the file.
4. Remove all the warning and errors like "Strict warning: Only variables should be passed by reference in node_page_view_404_is_restricted_role() (line 211 of /var/www/html/dcmood/sites/all/modules/contrib/node_page_view_404/node_page_view_404.module)."

Use http://pareview.sh for furthur development.

Thanks

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Nice module. Here are some recommendations:

1. In the .module file the node_page_view_404_form_alter function on lines 46 and 47 have some lines that extend very long. Consider breaking this into multiple lines to avoid one long line.
2. Consider renaming node_page_view_404_redirectTo to not be camel case. That would fit in with Drupal coding standards. https://www.drupal.org/coding-standards

That's it! Nice looking code :)

The only other thing I found is:

In node_page_view_404.info you have:

recommends[] = robotstxt

but it should be:

dependencies[] = robotstxt

Nice work with this. Looks like it gives users additional features over the Restrict Node Page View module. I've reviewed the module functionality, UI and code. I only have two suggestions

1. in in the UI config, /admin/config/content/node-page-view-404, I'd suggest setting the default #collapse state on all, or at least the first, fieldsets to FALSE to save the user a step.
2. Line 199 of node_page_view_404.module. If the user does not have site_404 configured (it's blank by default), the page will just redirect to the front page, an unintended result. One of these could be possible solutions:

   • if ($path) {
       drupal_goto($path);
     } else {
       drupal_not_found();
     }

   • Add a drupal_set_message(t('Your 404 is page not configured. You must configure it before you can select the Redirect To: Page Not Found option below')with a corresponding <code>hook_requirement() warning.

Otherwise, this work looks good to me.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.