Clean up the "help" component in Bartik

Uploaded the css file so it can reviewed with Dreditor

Added the file-comment. Properties grouped alphabetically.

@MarkoT91 Nice work! Don't forget to unassign yourself when you set an issue to 'Needs review', since people might mistake the assignee for a reviewer :)

I have just one minor suggestion:

+++ b/core/themes/bartik/css/components/help.css
@@ -1,7 +1,10 @@
+ * Bartik specific styling for help region.

Nitpick: this needs 'the' before 'help region' so it reads: 'Bartik specific styling for the help region.'

Done :)

Alright! I added a screenshot after patch to prove nothing broke:

Noticed an issue with the commenting standards (new line following the comment), will create a new patch and submit.

@zach.bimson Per our CSS formatting standards:

Note that a blank line should follow a @file documentation block.

It appears you removed the blank line after the @file documentation block. Can you cite your source for removing this line?

When working with a previous patch, could you include an interdiff for reviewers?

https://www.drupal.org/node/1887862#multi-line-comments

Same source as you, no new line appears after the comment

@emma.maria Actually that is exactly what it means :). Open a random css file in /core/modules/system/css to check, for example /core/modules/system/css/system.admin.css:

/**
 * @file
 * Styles for administration pages.
 */

/**
 * Reusable layout styles.
 */
.layout-container {
  margin: 0 1.5em;
}

[edit] Line breaks in <code> are broken, nice...

Assuming Emma and i misunderstood the documentation, I've provided a new patch in compliance to your suggestions

Created this... can someone check itIssue

Patch applied successfully. While we open the /core/themes/bartik/css/components/help.css file comments are applied properly.

as mentioned in #12 css standards applied.

There is no need to check the user interface, eventhough i checked it also attached the screenshot of it.

Reviewed & tested, please see comment above.

@emma.maria Actually that is exactly what it means :). Open a random css file in /core/modules/system/css to check, for example /core/modules/system/css/system.admin.css:

@idebr Thats a bad example, because the comment below the @file comment requires a comment above it. It seems like this is implemented really inconsistently in the CSS files. Looking through the PHP files, it seems like there is always a space below these comments. I guess we should just copy that?

The CSS standards are kind of vague, the @file PHP standards don't seem to mention blank lines... shall we update both of them to be more clear?

1. +++ b/core/themes/bartik/css/components/help.css
   @@ -1,5 +1,11 @@
   + * @file
   + * Styles for help pages.
   

   The styling here is actually for the help region, not for the help page. Actually I think we should update the name of this file as well so it matches the name of the class.

2. +++ b/core/themes/bartik/css/components/help.css
   @@ -1,5 +1,11 @@
   +/**
   + * Help.
   + */
   

   Having two comments here seems a bit redundant, would you mind removing this one?

I will be working on this today

I have changed the file name and removed the comment as described in #22.
Here are the two patches.

Uploading renamed interdiff. I forgot to mention to Ieva they need to be named .txt not .patch.

Bad mentor!

I think in #22Lewis was suggesting the comment should read "Styles for the help region." rather than help pages.

Apart from that, the filename was correctly changed etc.

Thank you @emma.maria. How exciting! I will try and do this today.

Just the tidyup to keep this moving - so close!!

Thanks, rachel_norfolk! Patch applies cleanly and updates the CSS file to all Drupal css standards.

I have added a beta evaluation to reflect this issue only changes CSS files.

Committed b705771 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.