Hi guys,

I submitted a couple of patches to get me familiar with the process (Emma threw them at me at DC Brighton today)
They were part of the clean up effort on the Bartik style sheets #2409069 & #2408581

Naturally there are tickets for each, with separate issues for each sheet but while i was at it i decided to update all the file comments and normal comments so they are consistent...

Ive added the patch but my concern was other people working on the other issues... if we can get this approved (providing it passes) and committed asap, everyone could pull and create their patch from an updated css file.

CommentFileSizeAuthor
#1 css-comment-cleanup-bartik-2409407-1.patch16.74 KBzach.bimson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zach.bimson’s picture

zach.bimson CreditAttribution: zach.bimson commented
FileSize
css-comment-cleanup-bartik-2409407-1.patch16.74 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Priority: Critical » Normal

Thanks for working on this, make sure to set the right priority, see the https://www.drupal.org/node/45111. I think we can agree that cleaning up CSS is not a release-blocking task :)

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Closed (won't fix)

Thanks for all the work Zach, but I don't think this is the right approach. We discuss the various approaches in #2372045: [META] The plan for Bartik and one of the reasons we split up the files is so we don't have to make really broad changes across all the files. We have a clean up issue for every file so it makes sense to make the comment changes there, otherwise this issue is going to require every individual issue to need a reroll.