Clean up unused images in the Seven theme

checked all files

found 2 references in tablesort-indicator.html.twig and forms.css.

changed markup in tablesort-indicator.html.twig to

{% if style == 'asc' -%}
  <span {{attributes.addClass('tablesort tablesort--asc') }}></span>
{% else -%}
  <span {{attributes.addClass('tablesort tablesort--dsc') }}></span>
{% endif %}

added css/components/tablesort-indicator.css

found missing @file in forms.css and forgot "." on @file comment in tablesort-indicator.css

@LewisNyman Yes, just saw tha the file is missing. I had some trouble with git, sorry for that.

I think it's that issue Replace arrow-asc and arrow-desc images with Libricons

I just investigated that a bit.

We need to make changes to modules/system/templates/tablesort-indicator.html.twig as shown in #2.

Then we could remove

function template_preprocess_tablesort_indicator(&$variables) {
  // Provide the image attributes for an ascending or descending image.
  if ($variables['style'] == 'asc') {
    $variables['arrow_asc'] = file_create_url('core/misc/arrow-asc.png');
  }
  else {
    $variables['arrow_desc'] = file_create_url('core/misc/arrow-desc.png');
  }
}

from theme.inc

In the next step all Themes can implement classes .tablesort and .tablesort--asc/dsc to customize the table- sorting item as prefered.

This also removes some unused files:

./themes/seven/images/add.png
./themes/seven/images/arrow-asc-active.png
./themes/seven/images/arrow-desc-active.png
./themes/seven/images/arrow-next.png
./themes/seven/images/arrow-prev.png
./themes/seven/images/task-check.png
./themes/seven/images/task-item-rtl.png
./themes/seven/images/task-item.png
^ Not used anywhere.

./themes/seven/images/arrow-asc.png
./themes/seven/images/arrow-desc.png
./themes/seven/images/required.svg
^ Replaced by libricon.

@stefan.r
Thanks :)

@LewisNyman
I didn't add the template file to the patch and if that got applied, we won't need an extra template file in Seven.

After

Un-postponing as the issue mentioned in #14 was committed and the Seven is not frozen for changes, so clean up tasks can take place.

We just need to check that the most recent patch in #13 has everything we need in it.

The most recent patch (#13) does not currently apply cleanly. It may need a re-roll.

@mccartj5 yes, if a patch cannot be applied cleanly it definitely needs a re-roll. Feel free next time to set the issue to "Needs Work" and also tag it with "Needs reroll".

We're taking a look at this as part of the sprint weekend.

Patch #13 generated the following errors:

~>git apply --check issue-2407955-13.patch
error: core/themes/seven/css/components/tablesort-indicator.css: already exists in working directory
error: patch failed: core/themes/seven/seven.libraries.yml:32
error: core/themes/seven/seven.libraries.yml: patch does not apply
error: patch failed: core/themes/seven/seven.theme:110
error: core/themes/seven/seven.theme: patch does not apply
error: core/themes/seven/templates/tablesort-indicator.html.twig: No such file or directory

We (leslieg and chuchunaku) made the following changes and re-rolled the patch:
deleted: core/themes/seven/images/add.png
deleted: core/themes/seven/images/arrow-asc-active.png
deleted: core/themes/seven/images/arrow-asc.png
deleted: core/themes/seven/images/arrow-desc-active.png
deleted: core/themes/seven/images/arrow-desc.png
deleted: core/themes/seven/images/arrow-next.png
deleted: core/themes/seven/images/arrow-prev.png
deleted: core/themes/seven/images/required.svg
deleted: core/themes/seven/images/task-check.png
deleted: core/themes/seven/images/task-item-rtl.png
deleted: core/themes/seven/images/task-item.png

modified: core/themes/seven/css/components/form.css

Looks good to me!

Applied the patch, successfully removed all the images in seven theme.
All looks good to go!

+++ b/core/themes/seven/css/components/form.css
@@ -91,7 +91,7 @@ label[for] {
-  background-image: url(../../images/required.svg);
+  background-image: url(../../../core/misc/icons/ee0000/required.svgg);

Thanks, this looks pretty reasonable (all the images removed do look to be unused and all of the remaining images in Seven are used) but this one line looks a bit off - svgg instead of svg I think :)

Updated patch file to remove that extra g in the css.

My bad, back to RTBC!

Thanks! Will take a look soonish :)

+++ b/core/themes/seven/css/components/form.css
@@ -91,7 +91,7 @@ label[for] {
-  background-image: url(../../images/required.svg);
+  background-image: url(../../../core/misc/icons/ee0000/required.svg);

So I looked at this closer and Classy's form.css has this CSS:

.form-required:after {
  content: '';
  vertical-align: super;
  display: inline-block;
  /* Use a background image to prevent screen readers from announcing the text. */
  background-image: url(../../../../misc/icons/ee0000/required.svg);
  background-repeat: no-repeat;
  background-size: 6px 6px;
  width: 6px;
  height: 6px;
  margin: 0 0.3em;
}

That makes the background-image line redundant. We can rely on Classy here and remove the line.

According to #27 here goes the patch
(maybe all the form-required:after is redundant?)

It is working. Can be made as RTBC.

@wellme that's great. Can you describe the tests you've done and change the status? Thanks!

• Checked the console whether any 404 errors are occuring.
• Using grep, checked whether deleted images are used anywhere in the seven theme.
• Confirmed whether the non-deleted images are actually used.

Great. Thanks @wellme

This is just cleanup so committing to 8.2.x only. Thanks all :)

d.o, you're weird. #36 is marked as "fixed", but here it says "needs review". WTF.