Several of the things that
template_preprocess_html() does (because it must) should not be done in the theme preprocess layer. They actually belong on a
HtmlResponse class; but since we don't have that, because
HtmlRenderer::renderResponse() returns a plain Symfony
Response, that's not yet the case.
So this patch paves the way for one of the most important steps towards BigPipe, and simplifies SmartCache.
Review & commit.
User interface changes
None. (Internal API changes only.)
Possibly: template_preprocess_html() is now called before the main 'page', 'page_top' and 'page_bottom' have been rendered. Not sure we need a CR for that as its not TRUE API, but rather a side effect.
Beta phase evaluation
|Issue category||Task because neither bug nor feature, but significantly paves the way for SmartCache/BigPipe.
From the IS:
|Issue priority||Major because blocks BigPipe, both of which are major.|
|Prioritized changes||The main goal of this issue is performance — indirectly, by paving the way for BigPipe.|
|Disruption||None. All internal.|
|#122||interdiff.txt||4.05 KB||Wim Leers|
|#122||move_attachment-2407195-122.patch||72.93 KB||Wim Leers|
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 97,116 pass(es). View
|#105||consider_removing-reroll-2407195-105.patch||67.18 KB||Wim Leers|
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 97,033 pass(es). View
|#120||move_attachment-2407195-120.patch||68.95 KB||Wim Leers|
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View