Uncaught TypeError when using with Media

Just came across the same issue. Attached patch adds Drupal.admin.* predefinitions everywhere used.
Two patches because one also cleans the whitespaces at EOL.

solved the problem for me

Can confirm that this solves the issue.

When javascript aggregation is enabled, this error prevented the user's ability to insert media into the WYSIWYG editor -- the modal dialog would fail to open entirely.

The patches also fix the issue for us, and allows us to turn javascript aggregation back on.

The patch in #3 fixes this issue nicely for me. Thanks!

The patch in #3 also fixes the warning message "drupal.admin is undefined" in the media browser, thanks!

I thinks it's RTBC?

Works for me. +1

Confirmed #3 fixes it.

Thank you, patch on comment #3 works for me!

#3 resolved the error, thank you. Please commit.

Though the patch prevent the JS warnings, it is not fixing the problem.

The problem is that object Drupal.admin is defined by the Admin Menu module in admin_menu.js which is not loaded in the Media browser iframe. Since this JS is not loaded, the attached behaviors to Drupal.admin (which is a custom behavior implementation) will never be fired. In my opinion the Adminimal Admin Menu's JS should not be loaded at all in the iframe.

Admin Menu attaches the JS using a rather specific $page['page_bottom']['admin_menu']['#attached'], while Adminimal Admin Menu uses drupal_add_js().

@lmeurs I have just suggested to use #attached before seeing your reply here.

Changed drupal_add_js and drupal_add_css to ['#attached'].
Increased the module weight, so adminimal_admin_menu runs after admin_menu.

Messing with the weights is a little fragile. Fixing the JS is the better option.

#20 work for me

agreed with #20.

but this will not correctly solve the issue because for now the admin_menu does not appear on my front website.

Please take also care about https://www.drupal.org/node/2902776

New patch based off of #2907586-6: Adminimal Administration Menu breaks display for Deferred JavaScript Execution option

Patch that includes white space fixes

Patch #24 fixed an issue I was having where the menu was not showing up when advagg was enabled and set to responsive. Came from #2907586: Adminimal Administration Menu breaks display for Deferred JavaScript Execution option

#24 is good for me, thx :)

Applied patch #1 , although patch #16 could be a great addition in a separate issue.

Just a heads up, you may know this but the “fixed” status auto-closes after 2 weeks. And shows some of the recent changes, helpful for tracking down regressions.