reveal functionality doesn't seems to work for foundation 5 [#2405509]

Comment	File	Size	Author
#6	zurb_foundation-reveal-functionality-6.patch	888 bytes	FiLeVeR10

Comment #1

yaelsho CreditAttribution: yaelsho commented 11 January 2015 at 18:06

Issue summary:

View changes

Log in or register to post comments

Comment #2

nickBumgarner CreditAttribution: nickBumgarner commented 16 January 2015 at 20:59

What are you trying to accomplish, having the Drupal messages display as reveal modals?

Log in or register to post comments

Comment #3

kevinquillen CreditAttribution: kevinquillen commented 17 January 2015 at 17:10

Try adding the attribute 'data-reveal' to the div that is displaying the modal.

See the 'Basic' example here: http://foundation.zurb.com/docs/components/reveal.html

Log in or register to post comments

Comment #4

FiLeVeR10 CreditAttribution: FiLeVeR10 commented 25 January 2015 at 02:50

@yaelsho does #3 solve your issue?

Log in or register to post comments

Comment #5

shauntyndall CreditAttribution: shauntyndall commented 25 January 2015 at 04:14

Version:	7.x-5.0-alpha8	» 7.x-5.x-dev
Component:	Miscellaneous	» Code
Category:	Support request	» Bug report
Priority:	Major	» Normal
Status:	Active	» Needs work

I'm gambling that theme_zurb_foundation_reveal() doesn't implement the "data-reveal" attribute (per the instructions referenced https://www.drupal.org/node/2052525). @filever10 can you attempt to replicate?

Log in or register to post comments

Comment #6

FiLeVeR10 CreditAttribution: FiLeVeR10 commented 1 February 2015 at 15:08

File	Size
zurb_foundation-reveal-functionality-6.patch	888 bytes

So I've tried out the process and can verify that adding data-reveal to the reveal container does in fact make the reveal work.

Also noticed that the href on the resulting link was "javascript:", so I also reset that to follow the foundation example of "#".

*One thing to note, when I enabled the subtheme on the latest 7.x-5.x it threw an error that prevented foundation from loading at the bottom of the page. I disabled libs.js in the subtheme and the error went away and the reveal works as it did on the base theme with the above changes.

Log in or register to post comments

Comment #7

yaelsho CreditAttribution: yaelsho commented 1 February 2015 at 17:36

#6 is working great (manually patched 7.x-5.0-alpha8 ver).
Thanks!

Log in or register to post comments

Comment #8

FiLeVeR10 CreditAttribution: FiLeVeR10 commented 2 February 2015 at 00:43

Status:

Needs work

» Needs review

@yaelsho you're welcome, I'm glad it's working for you! Hopefully it will get added in once it's reviewed.

Log in or register to post comments

Comment #9

yaelsho CreditAttribution: yaelsho commented 4 February 2015 at 13:02

Another issue related to Foundation 5 reveal:

When adding AJAX reveal modal, it work post the change in #6.
But post closing the AJAX reveal modal, and trying to open it again by clicking the same link, the reveal doesn't work as expected: The reveal-modal-bg doesn't toggle, and the modal opened in a shifted way (to high). The same issue appears if there are 2 different AJAX reveal modals in the same page, the first one will work great, when closing it, the 2nd modal will be opened in the same shifted way.

It seemed to me like some issue of initialization that need to be done/prevent while loading the ajax modal.
I tried to look into it, but didn't find a resolution.

Are you familiar with this issue?

I can open a different issue if you prefer to separate them.

Log in or register to post comments

Comment #10

kevinquillen CreditAttribution: kevinquillen commented 4 February 2015 at 14:05

There are known issues with the Reveal plugin itself in some more 'advanced' usages. I think I understand what you are describing as I have seen the same behavior. There are some issues with DOM state/refresh and binding in some cases.

https://github.com/zurb/foundation/issues?q=is%3Aissue+is%3Aopen+reveal

I do know that Foundation 5.5 released with a particularly nasty showstopper bug for reveal (related to positioning) - they may have resolved this by now.

Log in or register to post comments

Comment #11

yaelsho CreditAttribution: yaelsho commented 8 February 2015 at 10:50

To prevent the issue from #9, I've created a copy of html.tpl.php for the requested ajax node (html--node--id.tpl.php), and delete the following lines from the tpl copy:

  <script>
    (function ($, Drupal, window, document, undefined) {
      $(document).foundation();
    })(jQuery, Drupal, this, this.document);
  </script>

This prevent from foundation to initialized twice.
Got the idea from: https://github.com/zurb/foundation/issues/2928.

Log in or register to post comments

Comment #12

12 February 2015 at 02:34

shauntyndall committed 1ce34a4 on 7.x-5.x authored by FiLeVeR10

Issue #2405509 by FiLeVeR10: reveal functionality doesn't seems to work...

Log in or register to post comments

Comment #13

shauntyndall CreditAttribution: shauntyndall commented 12 February 2015 at 02:36

Status:

Needs review

» Fixed

Patch #6 has been tested & committed to the dev branch. Thanks @filever10! The other issue you noticed is also corrected. The libs.min.js need to be recompiled in the STARTER theme.