Problem/Motivation

MigrateAggregatorFeedTest.php tests the migrated feed hash. However, the hash field is not in the list of items to migrate in migrate.migration.d6_aggregator_feed.yml.

$this->assertEqual($feed->hash->value, '');

Proposed resolution

Migrate the hash.
Note that I tried to do this but the hash never appeared in the row.

Remaining tasks

Decide if the hash is to be migrated or not.
Modify and document MigrateAggregatorFeedTest.php based on that decision.

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#1 2403735-1.patch855 bytesbenjy

Comments

benjy’s picture

benjy commented
Status: Active » Needs review
StatusFileSize
new 2403735-1.patch855 bytes

src/Entity/Feed.php

    $fields['hash'] = BaseFieldDefinition::create('string')
      ->setLabel(t('Hash'))
      ->setDescription(t('Calculated hash of the feed data, used for validating cache.'));

D6 didn't have that equivalent so I think we should simply remove the test.

markie’s picture

markie commented
Status: Needs review » Reviewed & tested by the community

Applied patch and ran Aggregator tests with zero errors.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +SprintWeekend2015

Seems reasonable.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed e1f3f99 on 8.0.x 
    Issue #2403735 by benjy, markie, quietone: Migrate aggregator feed hash
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Migrate aggregator feed hash » Don't test aggregator feed hash migration, since the field doesn't exist in D6

Better title, perhaps.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.