Problem/Motivation

When fixing #2343173: HEAD BROKEN: Duplicate entry in migrate dump node_revisions table I came a across an issue caused by the use of assertEqual vs assertIdentical. I can't think of many good reasons to use assertEqual over assertIdentical so lets try convert as many as we can can in migrate_drupal.

Proposed resolution

Find and Replace assertEqual with assertIdentical and see what breaks. From there, decide how to fix each case.

Remaining tasks

Review the patch

User interface changes

n/a

API changes

n/a

Files: 
CommentFileSizeAuthor
#72 2345833-72.patch123.53 KBquietone
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,916 pass(es). View
#67 interdiff-65-67.txt645 bytesquietone
#67 2345833-67.patch121.59 KBquietone
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,649 pass(es). View
#65 2345833-65.patch121.23 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,337 pass(es), 2 fail(s), and 0 exception(s). View
#63 2345833-63.patch121.23 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,290 pass(es), 2 fail(s), and 0 exception(s). View
#56 2345833-56.patch120.84 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,137 pass(es), 1 fail(s), and 0 exception(s). View
#56 interdiff-54-56.txt1.48 KBquietone
#54 2345833-54.patch120.99 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,081 pass(es), 7 fail(s), and 0 exception(s). View
#52 2345833-51.patch121.04 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2345833-51.patch. Unable to apply patch. See the log in the details link for more information. View
#45 interdiff-43-45.txt2.29 KBquietone
#45 2345833-45.patch123.83 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,444 pass(es), 7 fail(s), and 0 exception(s). View
#43 2345833-43.patch123.83 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,449 pass(es), 7 fail(s), and 0 exception(s). View
#36 2345833-36.patch123.82 KBquietone
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,501 pass(es). View
#32 2345833-32.patch123.45 KBquietone
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,773 pass(es). View
#28 interdiff-26-28.txt617 bytesquietone
#28 2345833-28.patch122.72 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,774 pass(es), 4 fail(s), and 0 exception(s). View
#26 2345833-26.patch122.68 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,775 pass(es), 6 fail(s), and 0 exception(s). View
#26 interdiff-24-26.txt590 bytesquietone
#24 interdiff-20-24.txt4.72 KBquietone
#24 2345833-24.patch123.48 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View
#22 interdiff-19-20.txt13.16 KBquietone
#20 2345833-20.patch120.33 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,781 pass(es), 1 fail(s), and 0 exception(s). View
#19 2345833-19.patch110.12 KBquietone
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,531 pass(es). View
#19 interdiff-17-19.txt20.8 KBquietone
#17 interdiff-15-17.txt1.54 KBquietone
#17 2345833-17.patch103.59 KBquietone
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,587 pass(es). View
#15 2345833-15.patch101.89 KBquietone
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,586 pass(es). View
#15 interdiff-12-15.txt758 bytesquietone
#12 2345833-12.patch102.07 KBquietone
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,583 pass(es), 1 fail(s), and 0 exception(s). View

Comments

benjy’s picture

I was confused by so many integer fields coming back as strings so i've opened #2345813: Primitive TypedData fields are not cast properly

benjy’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, assert-identical-3.patch, failed testing.

ultimike’s picture

Benjy,

Is this something that we can have a newbie do? It doesn't seem like it is much more than a big search-and-replace...

-mike

benjy’s picture

Yes we certainly could make this a novice task. The reason I did it was to try find a few bugs and I actually think there are 2 or 3 in the failed test here that will all need separate issues.

quietone’s picture

I've been looking at this, seemed a good way to poke around.

What is the recommended way to compare arrays?

Line 136-138 of MigrateFieldInstanceTest.php states

 // This is the only way to compare arrays.
$this->assertFalse(array_diff_assoc($field->getSettings(), $expected));
$this->assertFalse(array_diff_assoc($expected, $field->getSettings()));

but that is the only case I found like that. Usually assertEqual is used.

benjy’s picture

Assigned: benjy » Unassigned

I was using assertIdentical but I think that also meant the order had to be the same. I'm not entirely sure if there is an agreed upon approach in core, many simply use assertEqual() which is fine unless you're asserting against an empty array.

chx’s picture

Either you do that to compare two arrays -- but even that compares only arrays that do not contain arrays. Here, look at this:

function kindaIdentical($v1, $v2) {
  return $v1 === $v2 || (is_array($v1) && is_array($v2) && kindaIdenticalArrays($v1, $v2));
}
function kindaIdenticalArrays(array $a1, array $a2) {
  if (count($a1) !== count($a2)) {
    return FALSE;
  }
  foreach ($a1 as $k => $v) {
    if (!isset($a2[$k]) || !kindaIdentical($v, $a2[$k])) {
      return FALSE;
    }
  }
  return TRUE;
}

use this. Put it in the NestedArray class, I would say. It's kinda useful: ['foo' => 'bar', 'this' => 'that'] is kinda identical to ['this' => 'that', 'foo' => 'bar'] after all.

quietone’s picture

@chx, thanks. But if the arrays are identical and contain a NULL, kindaIdenticalArrays will return False because "isset() will return FALSE if testing a variable that has been set to NULL".

quietone’s picture

Since strings are returned, then shall we keep assertEqual be kept for testing integers and NULL?

It is unexpected to get a string back when when an int was loaded. Is this behavior documented?

chx’s picture

> Is this behavior documented?

core/lib/Drupal/Core/Database/Driver/pgsql/Connection.php
98:      \PDO::ATTR_STRINGIFY_FETCHES => TRUE,

core/lib/Drupal/Core/Database/Driver/sqlite/Connection.php
114:      \PDO::ATTR_STRINGIFY_FETCHES => TRUE,

Kind of yes.

quietone’s picture

FileSize
102.07 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,583 pass(es), 1 fail(s), and 0 exception(s). View

@chx, thanks. That lead to some interesting reading.

The attached patch changes assertEqual to assertIdentical only when both arguments are strings. But without some standard future tests could be written with assertEquals and not assertIdentical. This looks like a good case for an agreed approach and documentation. Is that suitable for a documentation issue?

Still need to address comment #8.

quietone’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: 2345833-12.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
758 bytes
101.89 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,586 pass(es). View

Oops, left one line using assertIdentical on ''.

benjy’s picture

Status: Needs review » Needs work

When we're asserting against TRUE/FALSE I think we should change to assertIdentical, eg:

ests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->status->value, TRUE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->promote->value, TRUE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->sticky->value, TRUE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->status->value, TRUE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->promote->value, TRUE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->sticky->value, FALSE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->status->value, FALSE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->promote->value, FALSE);
./src/Tests/d6/MigrateNodeBundleSettingsTest.php:    $this->assertEqual($node->sticky->value, TRUE);

Main reason been that if you look at my patch from #3, I had failures like

Value NULL is identical to value false.	Other	MigrateUserTest.php	159	Drupal\migrate_drupal\Tests\d6\MigrateUserTest->testUser()

Which looks like a bug but assertEqual(NULL, false) will return TRUE!

quietone’s picture

Status: Needs work » Needs review
FileSize
103.59 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,587 pass(es). View
1.54 KB

Those failures seem to be the result of testing the empty string or NULL, not a TRUE/FALSE test. Anyway, MigrateNodeBundleSettingsTest.php has been changed to test integer to integer.

That just leaves 88 more to change and I should be able to do that over this weekend.

benjy’s picture

Those failures seem to be the result of testing the empty string or NULL, not a TRUE/FALSE test.

What I meant was, previously it was:

$this->assertEquals(NULL, FALSE); // Passes

And I changed to this:
$this->assertIdentical(NULL, FALSE); // Fails

That just leaves 88 more to change and I should be able to do that over this weekend.

Awesome, ping me if you need any help.

quietone’s picture

FileSize
20.8 KB
110.12 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,531 pass(es). View

Another installment. This just leaves the arrays plus a few others that are not straightforward. I need to look at those when I am not as tired as I am now.

@benjy, I may take you up on that offer, after this busy weekend.

quietone’s picture

FileSize
120.33 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,781 pass(es), 1 fail(s), and 0 exception(s). View
13.16 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch interdiff-19-20.patch. Unable to apply patch. See the log in the details link for more information. View

Managed to get some time and converted all but 3 assertEquals successfully.

Status: Needs review » Needs work

The last submitted patch, 20: interdiff-19-20.patch, failed testing.

quietone’s picture

FileSize
13.16 KB

And the interdiff, with a proper name.

The last submitted patch, 20: 2345833-20.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
123.48 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View
4.72 KB

Down to the last 3.

MigrateCckFieldValuesTest.php - Both failures relate to a multivalue field.
MigrateFieldInstanceTest.php - An array test with an empty string ('') that fails when assertIdentical is used.

Status: Needs review » Needs work

The last submitted patch, 24: 2345833-24.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
590 bytes
122.68 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,775 pass(es), 6 fail(s), and 0 exception(s). View

This should be right.

Status: Needs review » Needs work

The last submitted patch, 26: 2345833-26.patch, failed testing.

quietone’s picture

FileSize
122.72 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,774 pass(es), 4 fail(s), and 0 exception(s). View
617 bytes

MigrateFieldInstanceTest.php - No, it's not the empty string. I missed that the value is a float.

quietone’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 28: 2345833-28.patch, failed testing.

quietone’s picture

assertIdentical fails because the value being tested is either a float or a string, depending on which test is run. When MigrateCckFieldValuesTest is run by itself $planet_node->field_multivalue->value returns a string. When MigrateDrupal6Test is run $planet_node->field_multivalue->value returns a float. Why?

quietone’s picture

FileSize
123.45 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,773 pass(es). View

I think this it finished now. All but one assertEqual has been changed to assertIdentical. There are two cases which I guess should be addressed in separate issues.

1) field_multivalue is defined in two files, MigrateCckFieldValuesTest.php, as an integerl, and in Drupal6FieldInstance.php, as a decimal. When CckFieldValues test is run, it expects an integer casted as a string. But if the full d6 migration test is run first, it will create field_multivalue as a float with precision 2 and the returned string will be 'NN.00' not 'NN' as expected.

I changed MigrateCckFieldValuesTest.php to match the way field_multivalue is created in Drupal6FieldInstance.php and all tests pass, irregardless of the order. The allows the tests to pass but a better solution is to fix the duplication.

2) And a similar thing is going on with MigrateNodeTest.php at line 58. If run by itself $node_revision->revision_log->value is Null but when the complete set of tests is run $node_revision->revision_log->value is ''. The test on line 58 remains an assertEqual.

quietone’s picture

Status: Needs work » Needs review
benjy’s picture

+++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateUserTest.php
@@ -154,30 +154,35 @@ public function testUser() {
+      if (reset($signature_format)) {
+        $this->assertIdentical($user->getSignatureFormat(), reset($signature_format));
+      }
+      else {
+        $this->assertNull($user->getSignatureFormat());
+      }

Is this because of MigrateDrupal6Test? If so, we've done something similar before where we set a property in setUp() which doesn't run for MigrateDrupal6Test. Makes this clearer.

benjy’s picture

Also, not sure if you addressed my comments from #18, the test run of my first patch seem to be gone so I can't review them failures.

quietone’s picture

FileSize
123.82 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,501 pass(es). View

Patch not longer applies. So just a reroll.

quietone’s picture

@benjy, regarding comment #18 and #35.

What I meant was, previously it was:

$this->assertEquals(NULL, FALSE); // Passes

And I changed to this:
$this->assertIdentical(NULL, FALSE); // Fails

The assertIdentical fails because it does type checking. And since NULL is the only possible value of type null assertIdentical with anything other than a NULL will fail. Whereas. assertEqual does type juggling, NULL is converted to boolean FALSE and comparing FALSE to FALSE will pass.

So, to change any assertEqual with a NULL argument to an assertIdentical I changed NULL to match the type of the source. That seems to me a good way to do it, since in a migration one should know the source data well. Or am I missing your point?

regarding comment #34
Yea, wasn't sure how to tackle this one, so just tried this poor method. The property sounds like it would work and I'll look into it. But still confused why the source data is not consistent for these tests.

benjy’s picture

So, to change any assertEqual with a NULL argument to an assertIdentical I changed NULL to match the type of the source. That seems to me a good way to do it, since in a migration one should know the source data well. Or am I missing your point?

The point I was trying to make that it is unlikely that we want to assert something is NULL, it's possible but unlikely. Therefore, It would be good to confirm for every instance that NULL is exactly what we want. I think more likely, is that this could be indicative of a bug.

quietone’s picture

Oh, so you want to check all instances where NULL is used in an assert, all instances of assertNotNull, assertNull and when a parameter of an assert is tested for null, i.e.
$this->assertIdentical(is_null($form_display), FALSE, "Form display node.story.default loaded with config.");

Is that right?

chx’s picture

We have assertNull and assertNotNull for those. Both simpletest and phpunit.

benjy’s picture

As discussed in IRC, my point was asserting that something is NULL might be an incorrect change and indicative of a bug where something is not migrated.

quietone’s picture

Thanks for the the clarification.
Of the assertions involving NULL, most I can verify are checking that something does not exist and should stay.

The following files are the only ones that have tests that need a more experienced eye on them.

MigrateCommentVariableEntityFormDisplaySubjectTest

$component = entity_get_form_display('comment', 'comment_no_subject', 'default')
->getComponent('subject');
$this->assertNull($component);

MigrateUploadEntityFormDisplayTest.php

$display = entity_get_form_display('node', 'article', 'default');
$component = $display->getComponent('upload');
$this->assertTrue(is_null($component));

MigrateUserProfileEntityDisplayTest.php and MigrateUserProfileEntityFormDisplayTest.php
$this->assertNull($display->getComponent('profile_sell_address')); $this->assertNull($display->getComponent('profile_sold_to'));

MigrateFieldTest.php
$this->assertEqual($settings['default_image']['fid'], '');

Plus this one we talked about on IRC

MigrateAggregatorFeedTest.php - remove the test on 'hash' and creating a new issue to determine if hash needs to be migrated or not.

quietone’s picture

FileSize
123.83 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,449 pass(es), 7 fail(s), and 0 exception(s). View

I'm getting inconsistent test results since yesterday so uploading this patch.

Status: Needs review » Needs work

The last submitted patch, 43: 2345833-43.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
123.83 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,444 pass(es), 7 fail(s), and 0 exception(s). View
2.29 KB

Right, fixed MigrateNodeTest in attached patch. That leaves these two remaining instances of assertEqual.

  1. MigrateFieldTest.php
    $this->assertEqual($settings['default_image']['uuid'], '');

    $settings['default_image']['uuid'] is not set. But I'm not sure if it is migrated.

  2. MigrateUserTest.php
    $this->assertEqual($user->getSignatureFormat(), reset($signature_format));

I'd appreciate some suggestions on these two.

Status: Needs review » Needs work

The last submitted patch, 45: 2345833-45.patch, failed testing.

benjy’s picture

$this->assertEqual($settings['default_image']['uuid'], '');
I don't know why we're asserting a uuid, that surely didn't come from D6. I think the test can be deleted.

$this->assertEqual($user->getSignatureFormat(), reset($signature_format));
D8 stores NULL when the signature format is disabled. If we can get the user Id and check in the dumps it might tell us what the issue is.

ultimike’s picture

ultimike’s picture

Looking at

$this->assertEqual($user->getSignatureFormat(), reset($signature_format));

Changing this to

$this->assertIdentical($user->getSignatureFormat(), reset($signature_format));

and running the MigrateUserTest results in two fails, both when the D6 signature format = 0 (UIDs 16 and 17).

Since $signature_format is set earlier in the test, can't we just check to see if it is an empty array and set it to null if it is? Then assertIdentical will work.

-mike

benjy’s picture

If the signature format for user 16/17 is "0" in the dumps then that should run through the static map in the d6_user migration and the destination should be NULL.

So, $signature_format should be array(NULL) at this point and the assert identical check should work. If that's not the case, something else is going wrong?

benjy’s picture

Since $signature_format is set earlier in the test, can't we just check to see if it is an empty array and set it to null if it is? Then assertIdentical will work.

Took a closer look at this, what you said is nearly right. Apart from we need to check $source->filter_format === '0' rather than the result of the lookup in the idMap. We have a separate issue so I posted there: #2403815: Test migration of signature_format with assertIdentical

quietone’s picture

Status: Needs work » Needs review
FileSize
121.04 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2345833-51.patch. Unable to apply patch. See the log in the details link for more information. View

Rerolled, in preparation for returning home and working on this in the next few days.

Status: Needs review » Needs work

The last submitted patch, 52: 2345833-51.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
120.99 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,081 pass(es), 7 fail(s), and 0 exception(s). View

Lets try this reroll

Status: Needs review » Needs work

The last submitted patch, 54: 2345833-54.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
1.48 KB
120.84 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,137 pass(es), 1 fail(s), and 0 exception(s). View

New patch including changes suggested in #46 and #51.

#46 - Removed test for uuid.
#51 - Since there is a new issue for the testing of signature_format that is restored that to an assertEqual.

There should be one fail. It seems that my comment in #45 was incorrect and MigrateNodeTest.php still has a problem.
$this->assertEqual($node_revision->revision_log->value, '');

Status: Needs review » Needs work

The last submitted patch, 56: 2345833-56.patch, failed testing.

benjy’s picture

There should be one fail. It seems that my comment in #45 was incorrect and MigrateNodeTest.php still has a problem.
$this->assertEqual($node_revision->revision_log->value, '');

Seems like a bug, do you want to try track it down?

quietone’s picture

Yes, I would, and I've looked at it a bit, but l have far too many questions about migration and D8 in general to do it. I just wind up spinning my wheels, as the saying goes.

benjy’s picture

The first thing I would try would be to update the dump and the test to actually have a log message. It's possible something turns an empty string into NULL during processing. Hopefully it's as easy at that.

quietone’s picture

Well, I've found two things:

1. The test node created in MigrateNodeTestBase has a revision_log value of NULL.

    // Create a test node.
    $node = entity_create('node', array(
      'type' => 'story',
      'nid' => 1,
      'vid' => 1,
    ));

But when I create a node via the GUI the revision_log value is blank, presumably an empty string.

2. The migration of the revision_log value works when the string is not empty.

benjy’s picture

2. The migration of the revision_log value works when the string is not empty.

Based on this finding, lets either add a comment explaining this or update the dumps so we have a string and use assertIdentical. Whichever you prefer.

quietone’s picture

Status: Needs work » Needs review
FileSize
121.23 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,290 pass(es), 2 fail(s), and 0 exception(s). View

Added code to make the revision_log a string. Works for MigrateNodeTest but having trouble (again) getting the complete migration tests to run.

Status: Needs review » Needs work

The last submitted patch, 63: 2345833-63.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
121.23 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,337 pass(es), 2 fail(s), and 0 exception(s). View

Made a mistake rerolling.

Status: Needs review » Needs work

The last submitted patch, 65: 2345833-65.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
FileSize
121.59 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,649 pass(es). View
645 bytes

Sigh, another reroll mistake.

quietone’s picture

Good. And grep doesn't find any instances of 'assertEqual'.

benjy’s picture

Status: Needs review » Reviewed & tested by the community

Great work. I'm glad we've managed to get this green, I know it has been tedious but it has already proven elsewhere that it's a good way to catch bugs.

Thanks again.

quietone’s picture

Thanks. I couldn't have done this with out your help.

It did fulfill my goal of a being a good way to poke around. I know more about migration now and have heaps more questions.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
git ac https://www.drupal.org/files/issues/2345833-67.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  121k  100  121k    0     0   231k      0 --:--:-- --:--:-- --:--:--  231k
error: patch failed: core/modules/migrate_drupal/src/Tests/d6/MigrateBlockTest.php:85
error: core/modules/migrate_drupal/src/Tests/d6/MigrateBlockTest.php: patch does not apply
quietone’s picture

Status: Needs work » Needs review
FileSize
123.53 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,916 pass(es). View

Reroll.

benjy’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC

alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs reroll

Great - I think the increased strictness is worth it. Migrate is not blocked by the beta. Committed b1d2d7c and pushed to 8.0.x. Thanks!

  • alexpott committed b1d2d7c on 8.0.x
    Issue #2345833 by quietone, benjy: Convert assetEqual to assertIdentical...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.