Problem/Motivation

Converting assertEqual to assertIdentical on the $signature_format test in MigrateUserTest.php fails testing. It does pass either when UserTest is run by itself or the complete d6 tests are run. I don't recall which way round that is.

$this->assertEqual($user->getSignatureFormat(), reset($signature_format));

Proposed resolution

None yet

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2403815-1.patch1.38 KBbenjy

Comments

benjy’s picture

benjy commented
Status: Active » Needs review
StatusFileSize
new 2403815-1.patch1.38 KB

Patch attached, we need to handle filter formats which are "0" because they're not in the idMap but looked up in a static map in the migration file.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Reviewed & tested by the community

Benjy,

Yup, that works for me.

-mike

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 146069d and pushed to 8.0.x. Thanks!

  • alexpott committed 146069d on 8.0.x 
    Issue #2403815 by benjy: Test migration of signature_format with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.