Problem/Motivation

Titles are either defined via _title(_callback) on the routes, or as #title on the render array, in case you depend on the result of the controller.

#2359901: Discourage $main_content['#title'] in favor of route titles and title callbacks has a lot of fixes to use _title_(callback) in cases where its possible.

Proposed resolution

Take over those conversions into a new patch.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#12 interdiff.txt2.71 KBkgoel
#12 2403359-12.patch114.12 KBkgoel
#11 2403359-11.patch114.12 KBkgoel
#9 interdiff.txt1.36 KBkgoel
#9 2403359-9.patch114.35 KBkgoel
#6 2403359-6-do-not-test.patch114.07 KBkgoel
#3 use_route_title_wherever_possible-2403359-3.patch119.79 KBwim leers

Comments

dawehner’s picture

dawehner
Primary language German
commented
Related issues: +#2359901: Discourage $main_content['#title'] in favor of route titles and title callbacks

.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers

I'm rolling those fixes into a patch for this issue.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Active » Needs review
Issue tags: +DX (Developer Experience), +Usability
StatusFileSize
new use_route_title_wherever_possible-2403359-3.patch119.79 KB

I'd be very surprised if this passes. But the patch applies, and now somebody else can hopefully push it to the finish line.

IMO this is important for both Usability and DX: many titles are currently either wrong or missing (Usability), and the way much (if not most) of core is currently setting titles, has a bad DX, which contrib developers will hence also adopt.

Status: Needs review » Needs work

The last submitted patch, 3: use_route_title_wherever_possible-2403359-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

@kgoel at least planned to work on it.

kgoel’s picture

kgoel commented
StatusFileSize
new 2403359-6-do-not-test.patch114.07 KB

Just a re-roll since patch didn't apply. Looking into fails and exceptions.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

Since #3 has thousands of failures, and #6 is only a straight reroll to chase HEAD, I think this should be NW.

kgoel’s picture

kgoel commented
Status: Needs work » Needs review
StatusFileSize
new 2403359-9.patch114.35 KB
new interdiff.txt1.36 KB

It's not going to fix whole lot but trying just to get an idea.

Status: Needs review » Needs work

The last submitted patch, 9: 2403359-9.patch, failed testing.

kgoel’s picture

kgoel commented
StatusFileSize
new 2403359-11.patch114.12 KB

chasing head....

kgoel’s picture

kgoel commented
Status: Needs work » Needs review
StatusFileSize
new 2403359-12.patch114.12 KB
new interdiff.txt2.71 KB

Status: Needs review » Needs work

The last submitted patch, 12: 2403359-12.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Postponed

I think we want to postpone this on #2350509: Implement auto-route generation for all core entities and convert all of the core entities., since there is a lot of overlap, and much of this becomes obsolete with that.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Ugh, #2350509: Implement auto-route generation for all core entities and convert all of the core entities. got stuck, and hence this got stuck. But, looks like that issue is active again, so keeping postponed.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Related issues: +#2350509: Implement auto-route generation for all core entities and convert all of the core entities.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Title: Use a route title_callback/title in case its possible » Use _title and _title_callback where possible
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.1.x-dev » 8.3.x-dev
Status: Postponed » Active

Unpostponing this because the other issue is happening.

catch’s picture

catch
he/him
Primary language English
commented
Category: Bug report » Task
xjm’s picture

xjm
she/her
Primary language English
commented
Component: base system » routing system
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Triaged core major

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs issue summary update

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.