Problem/Motivation

similar to #2362065: Sort autocomplete of issue tags descending by usage count *in the issue metadata form*
there is a autocomplete for tags on the issue queue advanced search page

Proposed resolution

have the results sort on the issue queue advanced search page with the most used at the top.

Remaining tasks

User interface changes

Tags are sorted by usage.

API changes

Test the patch: https://autocomplete-drupal.redesign.devdrupal.org drupal/drupal bacon/bacon

Screenshots from patch #8

"Novice"

"Security"

"Usability", on all queues

Regression test:

CommentFileSizeAuthor
#12 Screen Shot 2015-03-18 at 10.05.08 AM.png46.74 KBwebchick
#12 Screen Shot 2015-03-18 at 10.06.26 AM.png77.19 KBwebchick
#10 Screen Shot 2015-03-18 at 8.34.02 AM.png226.57 KBcilefen
#10 Screen Shot 2015-03-18 at 8.34.14 AM.png224.48 KBcilefen
#10 Screen Shot 2015-03-18 at 8.34.40 AM.png235.09 KBcilefen
#10 Screen Shot 2015-03-18 at 8.35.54 AM.png142.71 KBcilefen
#8 sort_autocomplete_of-2398379-8.patch1.7 KBcilefen

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: Drupal.org customizations » Project issue tracking
Version: 7.x-3.x-dev » 7.x-2.x-dev
Component: Code » Issues

This should be implemented in Project Issue module, where the rest of the Issue-Tags-related, and SearchAPI hook implementation, code lives.

yesct’s picture

yesct commented

yay! #2362065: Sort autocomplete of issue tags descending by usage count *in the issue metadata form* is in, so we should do that here also.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Yeah, agreed. It's actually very confusing that it doesn't work the same way now.

cilefen’s picture

cilefen commented

@drumm Can we spin up a dev site for this?

drumm’s picture

drumm
he/him
Location NY, US
commented

Are you ready to start work on this in the near future?

cilefen’s picture

cilefen commented

I'm at the new Blink Reaction headquarters looking at it right now.

drumm’s picture

drumm
he/him
Location NY, US
commented

autocomplete-drupal.redesign.devdrupal.org will complete buildout in about 2h30m

cilefen’s picture

cilefen commented
Status: Active » Needs review
StatusFileSize
new sort_autocomplete_of-2398379-8.patch1.7 KB
cilefen’s picture

cilefen commented

@drumm Thank you. I think I've got it with that patch, but we need to verify.

cilefen’s picture

cilefen commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2015-03-18 at 8.35.54 AM.png142.71 KB
new Screen Shot 2015-03-18 at 8.34.40 AM.png235.09 KB
new Screen Shot 2015-03-18 at 8.34.14 AM.png224.48 KB
new Screen Shot 2015-03-18 at 8.34.02 AM.png226.57 KB

It works for me. Everyone, please test. https://autocomplete-drupal.redesign.devdrupal.org drupal/drupal bacon/bacon

Screenshots are in the summary.

cilefen’s picture

cilefen commented
Issue summary: View changes
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2015-03-18 at 10.06.26 AM.png77.19 KB
new Screen Shot 2015-03-18 at 10.05.08 AM.png46.74 KB

Looks great! Code, too. Let it be so. :D

Before:

After:

WIN.

  • drumm committed 59f21b0 on 7.x-2.x authored by cilefen 
    Issue #2398379 by cilefen: Sort autocomplete of issue tags descending by...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +needs drupal.org deployment
drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: -needs drupal.org deployment

Now deployed on Drupal.org.

yesct’s picture

yesct commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.