Write integration test for EditorImageDialog

@Wim Leers,

I was trying to make a test case that would validate the image's max dimension and resize it while upload. This piece of test can be useful to #2387011: EditorImageDialog passes incorrect arguments to file_validate_image_resolution issue. Need some of your help on this. The test case I've written so far is as following.
File: core/modules/editor/src/Tests/EditorImageDialogTest.php

/**
 * @file
 * Contains \Drupal\editor\Tests\EditorImageDialogTest.
 */


namespace Drupal\editor\Tests;

use Drupal\simpletest\WebTestBase;

/**
 * Tests Image Editor functionalities.
 *
 * @group editor
 */
class EditorImageDialogTest extends WebTestBase {

  /**
   * Modules to enable.
   *
   * @var array
   */
  public static $modules = array('filter', 'editor', 'editor_test', 'node');

  /**
   * An authenticated user to login.
   *
   * @var \Drupal\user\UserInterface
   */
  protected $adminUser;

  /**
   * An image file path for uploading.
   */
  protected $image;

  /**
   * Test case setup.
   */
  protected function setUp() {
    parent::setUp();

    // Add text formats.
    $full_html_format = entity_create('filter_format', array(
      'format' => 'full_html',
      'name' => 'Full HTML',
      'weight' => 1,
      'filters' => array(),
    ));
    $full_html_format->save();


    $this->adminUser = $this->drupalCreateUser(array(
      'use text format full_html'
    ));
  }

  /**
   * Tests the validations for image max resolution.
   */
  public function testMaxImageResolution() {
    // Set image resolution variables.
    $max_resolution = 100;

    // Only associate a text editor with the "Full HTML" text format.
    $editor = entity_create('editor', array(
      'format' => 'full_html',
      'editor' => 'unicorn',
      'image_upload' => array(
        'status' => FALSE,
        'scheme' => file_default_scheme(),
        'directory' => 'inline-images',
        'max_size' => '',
        'max_dimensions' => ['width' => $max_resolution, 'height' => $max_resolution],
      )
    ));
    $editor->save();
    // Login the user.
    $this->drupalLogin($this->adminUser);
    // Editor dialog page.
    $this->drupalGet('editor/dialog/image/full_html');

    // Get images test images based on the given resolution.
    $suitable_image = FALSE;
    $image_factory = $this->container->get('image.factory');
    foreach ($this->drupalGetTestFiles('image') as $image) {
      $image_file = $image_factory->get($image->uri);
      if ($image_file->getWidth() > $max_resolution) {
        $suitable_image = $image;
      }
      if ($suitable_image) {
        break;
      }
    }
    // Construct the form submit.
    $edit = array(
      'attributes[src]' => drupal_realpath($suitable_image->uri),
      'attributes[alt]' => 'Test Image file',
    );
    $this->drupalPostForm(NULL, $edit, t('Save'));
  }
}

I am not able to see the message in the editor page "editor/dialog/image/full_html" as The image was resized to fit within the maximum allowed dimensions of 100x100 pixels. Since there one issue with the EditorImageDialog::buildForm() to take wrong array parameters as for image resolution validation, I have also fixed that one.

diff --git a/core/modules/editor/src/Form/EditorImageDialog.php b/core/modules/editor/src/Form/EditorImageDialog.php
index a493dea..9b200fa 100644
--- a/core/modules/editor/src/Form/EditorImageDialog.php
+++ b/core/modules/editor/src/Form/EditorImageDialog.php
@@ -52,8 +52,8 @@ public function buildForm(array $form, FormStateInterface $form_state, FilterFor
 
     // Construct strings to use in the upload validators.
     $image_upload = $editor->getImageUploadSettings();
-    if (!empty($image_upload['dimensions'])) {
-      $max_dimensions = $image_upload['dimensions']['max_width'] . '×' . $image_upload['dimensions']['max_height'];
+    if (!empty($image_upload['max_dimensions'])) {
+      $max_dimensions = $image_upload['max_dimensions']['width'] . 'x' . $image_upload['max_dimensions']['height'];
     }
     else {
       $max_dimensions = 0;

Am I missing something in the test case?

Uploading a patch that might help someone to check for the issues I was referring to in comment #1.
FYI not for bot review as of now.

You can run the test anyway, it will happen sooner or later anyway.

@Berdir,

I did locally but this should give an message "The image was resized to fit within the maximum allowed dimensions of 100x100 pixels" but it's not.

I think there may be coding issue with the test that I've written. It will be good if you or anyone can have a look after applying it locally.

@Wim Leers, great!! I will have a go on this.

@WimLeers, Uploading a basic test file. This does the following test validations,

1. Tests form validation for the image editor form.
2. Validates the editor object with pre loaded value.

Please review this and let me know what more can I add and improve in this patch.

Thanks!

Adding #2588013: <span class="ajax-new-content" style="display:inline-block;"> causes unwanted whitespace as a related issue.

#2588013: <span class="ajax-new-content" style="display:inline-block;"> causes unwanted whitespace is not related with this Issue.

@WimLeers, thanks for reviewing the patch. I have some queries from #13. Though I'll ping you asking for those in IRC but I am also writing my queries here as well.

• #13.6: So what do you suggest on this? Should we check like the following:

  $this->assertText('Image field is required');
  $this->assertText('Alternative text is required.')
  

  Or you have any better ideas?

• #13.9:
  Well yes, this is like EditorImageDialogTest::testEditorImageDialog() and I've tested the loading of the editor with pre-loaded values. I've tried with drupalPost() but might have misses something. So, where should the value will be posted? Is it going to be on drupalPost('editor/dialog/image/full_html') or on a node creation page? I'll discuss with you on this point in IRC. Right now I can't be online :(

Please let me know your thoughts. Thanks!

This issue was discussed at a Bug Smash Initiative group triage meeting.

There has been no activity here for 7 years. Is this still valid? Perhaps, the test needed here was added in #2628656: Max dimensions do not apply to Editor Inline image or another issue?

Changing to PMNMI to determine if this still needs to be done before someone spends time on a patch,

Since there hasn't been a follow up to #27 going to close for now.

If still valid please reopen updating IS with what is still needed.

Thanks everyone!