Problem/Motivation

The addition of contextual links under #2231051: Add contextual links to OG Menu blocks introduced several bugs.

  • An empty og menu displays
  • Contextual module might not be enabled

Proposed resolution

  • Check if contextual module is enabled.
  • Add a variable that allows the ability to enable/disable contextual links.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#2 og_menu-contextual_links_make-2395087-2.patch3.24 KBheddn
#1 og_menu-remove_contextual_links_if_menu_empty-2395087-1.patch596 bytesazinck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

azinck’s picture

azinck CreditAttribution: azinck commented
Status: Active » Needs review
FileSize
og_menu-remove_contextual_links_if_menu_empty-2395087-1.patch596 bytes

Fix attached. We should follow the lead set forth by menu_block_view() and only add the contextual links if there are menu links in the menu.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
FileSize
og_menu-contextual_links_make-2395087-2.patch3.24 KB

Some improvements are included in this patch:

  • single and multimenu are addressed
  • The path in the contextual menu is/was wrong. OG group members don't necessarily have access to admin/structure/menu/manage, but they do have access to the group/{group_type}/{gid}/admin/menus/{menu_name} link.
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

I just did a fresh install of vanilla D7.34 and og_menu to test this. On my client's site, they are hiding contextual links on blocks so I wanted to test this on a site that wasn't hacked so much. The contextual links hide/show depending on if there are any menu items. I'm not going to mark RTBC, because I don't like doing that on my own patch, but the patch does have more than my typical testing.

azinck’s picture

azinck CreditAttribution: azinck commented
Status: Needs review » Reviewed & tested by the community

#2 works well for me; thanks for updating my oversights, heddn.

rv0’s picture

rv0 CreditAttribution: rv0 commented
Status: Reviewed & tested by the community » Fixed

Thanks guys!

  • rv0 committed 7ccaad9 on 7.x-3.x authored by heddn 
    Issue #2395087 by heddn, azinck: Contextual links make menu display as...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.