[D7] Quran Importer

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxhassan22383861git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I have pulled your project, tested and installed it. No errors found and it works as suggested. But I am concerned about the zip files included in the resource folder. I think, you should remove at least some of them because in my opinion they're not necessary. They can be downloaded from your suggested site.

Apart from that it works great with no errors.

• You can remove the .gitignore file
• The README should wrap at 80 characters
• Your .info file is missing a required core = 7.x directive, see https://www.drupal.org/node/171205. This info file does not resemble features' usual output - there should be some dependencies listed here at least. Maybe there was an error when exporting the module from features?
• The module's README seems to think users will download the CSV, but it's also provided with the module. Also I think the admin will need to unzip the file(s) before importing with feeds
• The url in the README should be https://github.com/azvox/quran-csv/blob/master/resources/quranall-online.csv.zip like on the project page

Manual review

Your git clone should be like this :

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/hassan2/2383861.git quran_importer
cd quran_importer

The git clone command is for your private account. You need to post the the public git clone command. On your sandbox page select the 'version control' tab, then deselect 'maintainer', then click on the 'show' button, then copy and paste the git clone command.

The git clone command now works, but it did not when I commented yesterday. I did not keep a record of the specific command, so I can't say if they are the same.

The git command works for me, but it doesn't seem to include your most recent changes. The .gitignore file is still there, as well as the zip files in the Resources directory. I'll happily review when those changes are pushed.

1) Add description and core = 7.x in your *.info file.
see details:- https://www.drupal.org/node/542202

2) You should Follows guidelines for in-project documentation and/or the README Template.

Great initiatives!!! But unfortunately your module looks to me little bit strange. You mentioned about lots of dependencies. Those are not added in .info files plus some major other things also missing in info file. It contains feature files which is not very good as contrib module and i never seen such structure before. If you can make it more generalised then it would be really great.

It also hard to change according to project. I can change views and other settings then i need to push all changes to my repo. I would like it to be more general and hook Api to change something from other module. Otherwise As i understand it will be just a feature module in own project and changes needs to be committed.

Downloaded code from below git command
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/hassan2/2383861.git quran_importer

Found below observations:
1. Info file missing description,core,dependencies
2. Please remove .gitignore file
3. filename: quran_importer.features.inc line no 63 & 64, having file path..need to add/manage logic to handle error if no such file/path exists. You project having dependency of mediafront and feeds modules. please mention in readme file.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.