Remove usages of drupal_is_front_page.

well you didn't actually remove the function itself and hence the file path.inc

ok great, in the future it's always good if you add any related issues in the summary.

Have you created an issue taking care of LinkGeneratorTest?

(sorry fat fingers so accidently added the q in summary

Given how small that patch is I think we could also work on the LinkGeneratorTest bit here.

Otherwise this patch looks great, if green.

Alright, so let's be honest here.

Re-rolled the patch

Sorry didn't see the '-' sign on Needs re-roll

Sorry ,it was by mistake

this is my patch, please review.

Patch applied cleanly and no occurrences of call to drupal_is_front_page(). Good to mark as RTBC.

Hi

I got some questions about this reroll, in core/modules/Language/src/Plugin/Block/LanguageBlock.php the patch made by @JeroenT added some code, this is now gone. Why?

Stated in comment 4,5 and 6 we chould also take care of the call to drupal_is_front_page in LinkGeneratorTest, this is not done.

rerolled

Trying to fix a fatal error of the patch in #15.
I guess it will help with exceptions.

well something has gone really wrong here in #15 so done a reroll from first patch and will also fix LinkGenerator bf uploading.

sorry for this but it was easier for me to base this on first patch and do a reroll and removed the drupal_is_front_page in linkgeneratortest than trying to figure out what was wrong with later patches.

The patch remove the use of drupal_is_front_page() and drupal works well.

   * @todo Test that the active class is added on the front page when generating
   *   links to the front page when drupal_is_front_page() is converted to a
   *   service.

in \Drupal\Tests\Core\Utility\LinkGeneratorTest - this should be converted to a @todo pointing to a new issue about adding tests that active class is added on the front page.

thanks @alexpott, was unsure how to deal with that and was uncertain if it still was a valid todo.

+++ b/core/modules/language/src/Plugin/Block/LanguageBlock.php
@@ -34,6 +35,13 @@ class LanguageBlock extends BlockBase implements ContainerFactoryPluginInterface
+   * @var \Drupal\Core\Path\PathMatcher

@@ -44,10 +52,13 @@ class LanguageBlock extends BlockBase implements ContainerFactoryPluginInterface
+   * @param \Drupal\Core\Path\PathMatcher $path_matcher
...
+  public function __construct(array $configuration, $plugin_id, $plugin_definition, LanguageManagerInterface $language_manager, PathMatcher $path_matcher) {

Note: We have a PathMatcherInterface, so let's use it.

Patch in #32 applied cleanly, also checked for drupal_is_front_page() and no occurrences of it.

Great, I think this is done then.

This doesn't seem right, possible because of this #2417549: Drupal\migrate_drupal\Tests\d6\MigrateFileTest fail in MigrateTestBase
I guess the patch is ok.

Committed 7c0e0e0 and pushed to 8.0.x. Thanks!

The beta evaluation is in the meta issue.