Files: 
CommentFileSizeAuthor
#9 2388629-9.patch2.33 KBCanutza
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 87,230 pass(es). View
#4 drupal_is_front_page_removed-2388629-4.patch576 byteskajalkiran
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,859 pass(es). View

Comments

rpayanm’s picture

Issue summary: View changes
kajalkiran’s picture

Issue tags: +documentation, +d8dx, +DX (Developer Experience), +novice documentation, +Novice, +Amsterdam2014, +dcdelhi
kajalkiran’s picture

Assigned: Unassigned » kajalkiran
kajalkiran’s picture

FileSize
576 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,859 pass(es). View

I have removed the test for checking drupal front page from core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php

kajalkiran’s picture

Status: Postponed » Needs review
dawehner’s picture

Note: We still have this as part of the test code.

   *
   * @todo Test that the active class is added on the front page when generating
   *   links to the front page when drupal_is_front_page() is converted to a
   *   service.
rpayanm’s picture

Status: Needs review » Postponed
alexpott’s picture

Status: Postponed » Active
Issue tags: +Kill includes

This issue should also remove the path.inc file.

Canutza’s picture

FileSize
2.33 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 87,230 pass(es). View

Reroll

JeroenT’s picture

Assigned: kajalkiran » Unassigned
Status: Active » Needs review

Go testbot!

JeroenT’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The function drupal_is_front_page is removed and all test still pass.

The beta evaluation is in the meta issue.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Just dead code now, nice bonus that path.inc is gone.

Committed/pushed to 8.0.x, thanks!

  • catch committed 94266ed on 8.0.x
    Issue #2388629 by kajalkiran, Canutza: remove drupal_is_front_page()
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

YesCT’s picture

Issue tags: -novice documentation

removing the combined "novice documentation" tag, since we should be able to make a search for the novice tag combined with the documentation tag https://www.drupal.org/project/issues/search?projects=&project_issue_fol... or maybe even better: the documentation component combined with the novice tag https://www.drupal.org/project/issues/search/drupal?project_issue_follow...