Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Follow-up of: #2388627: Remove usages of drupal_is_front_page..

Remove the function drupal_is_front_page().

CommentFileSizeAuthor
#9 2388629-9.patch2.33 KBmihai7221
#4 drupal_is_front_page_removed-2388629-4.patch576 byteskajalkiran

Comments

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Issue summary: View changes
kajalkiran’s picture

kajalkiran commented
Issue tags: +Documentation, +d8dx, +DX (Developer Experience), +novice documentation, +Novice, +Amsterdam2014, +dcdelhi
kajalkiran’s picture

kajalkiran commented
Assigned: Unassigned » kajalkiran
kajalkiran’s picture

kajalkiran commented
StatusFileSize
new drupal_is_front_page_removed-2388629-4.patch576 bytes

I have removed the test for checking drupal front page from core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php

kajalkiran’s picture

kajalkiran commented
Status: Postponed » Needs review
dawehner’s picture

dawehner
Primary language German
commented

Note: We still have this as part of the test code. 

   *
   * @todo Test that the active class is added on the front page when generating
   *   links to the front page when drupal_is_front_page() is converted to a
   *   service.
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs review » Postponed

Postponed because #2388627: Remove usages of drupal_is_front_page..

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Postponed » Active
Issue tags: +Kill includes

This issue should also remove the path.inc file.

mihai7221’s picture

mihai7221 commented
StatusFileSize
new 2388629-9.patch2.33 KB

Reroll

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Assigned: kajalkiran » Unassigned
Status: Active » Needs review

Go testbot!

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The function drupal_is_front_page is removed and all test still pass.

The beta evaluation is in the meta issue.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Just dead code now, nice bonus that path.inc is gone.

Committed/pushed to 8.0.x, thanks!

  • catch committed 94266ed on 8.0.x 
    Issue #2388629 by kajalkiran, Canutza: remove drupal_is_front_page()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yesct’s picture

yesct commented
Issue tags: -novice documentation

removing the combined "novice documentation" tag, since we should be able to make a search for the novice tag combined with the documentation tag https://www.drupal.org/project/issues/search?projects=&project_issue_fol... or maybe even better: the documentation component combined with the novice tag https://www.drupal.org/project/issues/search/drupal?project_issue_follow...