Menu Management Languages is a super light and simple module to improve the usability of the menu management administration interface in multilingual sites. It's intended to use with Drupal 7.

When you're building a multilingual site, if you have a taxonomy vocabulary with terms in different languages and you edit the terms of that vocabulary (Admin > Structure > Taxonomy, then click on the "list terms" link of one multilingual vocabulary), you can see the language of each term next to it.

But, if you have a multilingual menu with menu items in different languages, when you edit the menu items of that menu (Admin > Structure > Menus, then click on the "list links" link of one multilingual menu), you can't see in which language each menu item is. This can go even worse if the translation of the menu item is the same for different languages. This makes the managament of these menus pretty hard.

This module tries to fix this problem, adding the language name each menu item belongs to next to the menu item in the administration interface.

More information and screenshot on the Menu Management Languages' project page.

Git clone command: 

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/GoddamnNoise/2383525.git menu_management_languages
cd menu_management_languages

Reviews of other projects

https://www.drupal.org/node/2339751#comment-9478565
https://www.drupal.org/node/2272331#comment-9478597
https://www.drupal.org/node/2369183#comment-9478651

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxGoddamnNoise2383525git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

GoddamnNoise’s picture

GoddamnNoise commented

All the problems detected by the PA robot are fixed now.

GoddamnNoise’s picture

GoddamnNoise commented
Status: Needs work » Needs review
luke_nuke’s picture

luke_nuke commented

I won't pretend that this is a review, but I feel like this project won't be promoted because it doesn't satisfy guidelines for project length.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Project length is not a problem at - we just can't give the git vetted user role away but we can always promote the project for the applicant.

@Luke_Nuke: can you help me make the page better? Why did you get the impression that the project won't get promoted?

luke_nuke’s picture

luke_nuke commented

Oh, I forgot that there is an option to promote project without giving vetter user role. I'm sorry, my fault :) .

Swarnendu-Dutta’s picture

Swarnendu-Dutta commented
Status: Needs review » Needs work

Thanks a lot for your contribution.

Manual Review

Review of the 7.x-1.x branch (commit f686fb4):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...ar/www/drupal-7-pareview/pareview_temp/menu_management_languages.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
25 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------

Rest all looks good :-)

GoddamnNoise’s picture

GoddamnNoise commented

Hi Swarnendu-Dutta,

I know that warning is present, but it's a warning, not an error. Please, take a look at the line reported in the warning. That line is translating the language name, so it's safe and it's also required to translate the language name so it's showed in the same language the user is navigating the website.

This is the code which is making that warning to show up:

$language_name = t($language->name);

And this is the exact same thing, extracted from the 852-854 lines of the locale.module in the Drupal 7.34 core:

foreach ($languages as $language) {
  $list[$language->language] = ($field == 'name') ? t($language->name) : $language->$field;
}

As the warning message states: "Only string literals should be passed to t() where possible", and in this case, this is the only way to get the language name translated. That's the reason why Drupal core does the same thing.

Anyway, if you think the module can't be approved while that warning is still there, please, tell me and i'll remove the translation of the language name.

GoddamnNoise’s picture

GoddamnNoise commented
Status: Needs work » Needs review
Swarnendu-Dutta’s picture

Swarnendu-Dutta commented
Status: Needs review » Reviewed & tested by the community

Yes, according to API doc, we can use t() for variable names that has been passed through t() elsewhere and should not be some text that a user entered.

So i guess all OK..

Marking as RTBC. Please participate in the review bonus program, so that you get a review from GIT administrator.

GoddamnNoise’s picture

GoddamnNoise commented

Thanks a lot, Swarnendu-Dutta!

GoddamnNoise’s picture

GoddamnNoise commented
Issue summary: View changes
GoddamnNoise’s picture

GoddamnNoise commented
Issue summary: View changes
GoddamnNoise’s picture

GoddamnNoise commented
Issue summary: View changes
GoddamnNoise’s picture

GoddamnNoise commented
Issue tags: +#PAReview: review bonus
pushpinderchauhan’s picture

pushpinderchauhan commented
Issue tags: -#PAReview: review bonus +PAreview: review bonus

Corrected review bonus tag so that it appears at right place. https://www.drupal.org/project/issues/search?text=&projects=&assigned=&s...

GoddamnNoise’s picture

GoddamnNoise commented

Thanks!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Menu Management Languages for Drupal 7 » [D7] Menu Management Languages
Status: Reviewed & tested by the community » Fixed
Issue tags: -#drupal7 +PAreview: single application approval
Code too short
This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

But otherwise looks good to me.

Thanks for your contribution, GoddamnNoise!

I promoted this project for you: https://www.drupal.org/project/menu_management_languages

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

GoddamnNoise’s picture

GoddamnNoise commented

Thanks a lot for your help, Klausi and for all the links to useful resources!.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.