Drupal 8 port?

I think theCrow had big plans for a 7.x-3.x-dev version, with a change of architecture. And I think a complete refactoring would be a good thing moving forward (maybe abusing the new Plugin system?).
That said, I currently have neither a plan nor time to port Service Links to D8, and I've not seen theCrow in the issue queue in a long time, so I think we're currently looking for someone willing to tackle it...

Any update on this?
I think we should create new plugin type with name ServiceLink and create ServiceLink type plugin for each service.

I've done some basic work, will improve it further, comments and suggestions are welcome

I've updated my patch, to test it you need to comment out all code from module file.
Let me know if this approach looks good.

Can we create first alpha (dev) version for 8.x?

In the interests of revisiting this, because I liked service_links so much, I took Sharique's patch and made a github repository on an 8.x-1.x branch here. https://github.com/HongPong/service_links Hopefully people are down to review this thing

I got this report from running the latest drupalmoduleupgrader against 7.x-2.x HEAD. (attached).

Also attached here is a patch from a partially successful run of the drupalmoduleupgrader before it errored out with

service_links does not implement hook_@hook.    [warning]
Error at line 1:69: expected T_VARIABLE

against 7.x-2.x . It did cover a bunch of stuff that Sharique patch did not, though I am attaching this to my github repo as branch "8.x-autoconvert-partial".

The error was on the attempt to convert the permissions hook I see now. I posted on a gist here https://gist.github.com/HongPong/4604747cc4f0784edc5f2715377fa69e
Line 69 may be the return $hooks in service_links.module :

/**
 * Implements hook_hook_info().
 */
function service_links_hook_info() {
  $hooks = array(
    'service_links' => array(
      'group' => 'service_links',
    ),
    'service_links_alter' => array(
      'group' => 'service_links',
    ),
    'service_links_node_settings_alter' => array(
      'group' => 'service_links',
    ),
  );

  return $hooks;
}

see https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...

There are tons of sub modules in this thing so I would suspect they should be removed first to proceed more cleanly, then added back as needed.

It needs work in the menu.yml file, nothing there yet on either side. https://www.drupal.org/docs/8/creating-custom-modules/add-a-menu-link

I'm doing some work on this module and have forked HongPong's repo to: https://github.com/NigelCunningham/service_links.

Regards,

Nigel

Hi all.

Since the last comment, I've done a lot more work on the Service Links module D8 port, and would like to get some feedback please.

Service links are now implemented as a field that can be added to custom blocks, entities and so on. To avoid requiring the same configuration to be done over and over for different contexts, sets of links can be configured in the sitewide config. These links are then added as a field to the appropriate entity, and the display settings on the entity control whether images. text or both are displayed (among other options), and also whether the Fisheye styling is used.

I've cleaned up a lot of definitions for services that were broken, and added unit tests for a good portion of the code.

Work still to do:
- More unit tests
- More cleanup / moving settings from the link definitions to the display settings.

Looking forward to feedback; I'm sure there are things that can be done better but I think I need someone with a fresh perspective to give me input there.

New repo for the port (I'm moving from Github to Gitlab): git@gitlab.com:nigelcunningham/service_links.git

hi NigelCunningham I think you'll have to adjust the permissions on the project. I don't see it yet :)

https://gitlab.com/users/nigelcunningham/projects

Thank you for making headway. I always liked service_links

Ah. I didn't realise Gitlab makes repos private by default. Fixed now, thanks!

Here's a complete diff between the 7.x-1.x branch and 8.x-1.x.