Introduce an option to cache_clear_all() on Scheduler cron

I think the testbots are having trouble. I have seen this error on a different project an hour ago. I don't think it's anything to do with your patch.

I will test your patch and review it. Thanks

Also, just to let you know, we had a major effort to get all existing 7.x issues and patches committed before we released 7.x-1.3. The one issue remaining which was too dangerous to rush through is #2170353: Reduce memory footprint which is going to be the next commit as it touches the whole of .module. If we commit anything else before that one, then it will need constant re-rolls, so we decided that this will be the first, and any other patches can then be re-rolled.

Just an idea, are you using the lightweight scheduler cron to have cron run more often than the full cron? If so, we could just add the cache_clear_all() in to function _scheduler_run_cron(). Maybe we should do that anyway, now that it's not done in scheduler_cron()?

This looks good.

.install - all ok

.module - need to adjust the text as per #7 above. The checkbox gets a bit lost on the page, having no title, but that's not your fault. However, I can't see it would be better in any other place on the form.

.test - you've done a lot of work here. Particularly, you have changed the way we test for the basic published/unpublished node by going to the node and testing for response 403, instead of asserting that node body text is not on the front page. I like that. Thanks also for documenting the @param descriptions. These early tests were written by neither of the current maintainers - we'd always add descriptions ;-)
I'm not sure we need such an amount of detail about Elysia Cron in the .test file. You can reference this issue to give background for future maintainers.

The above is only one opinion, I'd like Pfrenssen's view on this too.

I reviewed this as part of a bigger (internal) ticket that I'm working on with PieterDC where we work, and the patch seems fine to me as well.

I agree that the example explanation of Elysia cron might be unnecessary, but I'll let you guys decide about that.

But if I understood correctly this will need to be re-rolled after #2170353: Reduce memory footprint is committed, so we'll need to follow this up later.

Not setting this to RTBC so we can await Pfrenssen's opinion if he wants to pitch in.

Hi bertramakers, yes you are right, the code split patch was always going to be the first commit after releasing 7.x-1.3. That has now been done so you can re-roll your patch.

This seems to apply and do the trick still.

Hi iSoLate,
The patch applies OK to the release 7.x-1.3 but it no longer applies to the 7.x-dev code, as per the comments in #17 and #18. I cannot find a way to re-queue the existing patch, maybe because testing is no longer done on qa.drupal.org and has been superseded by DrupalCI.

Hence I have re-added the same patch from #1 here, to see what happens.

As expected the existing patch does not apply. Here's a re-rolled version for the latest 7.x-1.x-dev code. I moved the new checkbox into the lightweight cron tab, as it is only really required when not running the full cron.

This feature will have to be added to the 8.x code first.

This has its use case on Drupal 7. It's a bit of a shotgun approach, and it's not _really_ Scheduler's responsibility and a bit of an edge case, but I can understand that this can be useful in situations such as explained in the issue summary. Since it is disabled by default this does not harm anyone.

In Drupal 8 this should not be needed. Thanks to the adoption of cache tags if a piece of content is published or unpublished, all related cache entries will automatically be invalidated. There is luckily never a need to do a full cache clear on a production instance on Drupal 8.

+++ b/scheduler.admin.inc
@@ -404,6 +404,12 @@ function _scheduler_lightweight_cron($form, &$form_state) {
+  $form['scheduler_cron_settings']['scheduler_cache_clear_all'] = array(
+    '#type' => 'checkbox',
+    '#title' => t('After publishing or unpublishing during cron, clear all expired block and page caches.'),
+    '#default_value' => variable_get('scheduler_cache_clear_all', 0),
+    '#description' => t('Makes the Scheduler cron task clear caches instead of relying on the Drupal core System cron task.'),
+  );

I would add a warning here that enabling this can have a serious impact on performance.

Thanks @pfrenssen for the explanation about Drupal8 tags. I was hoping that this was not going to be required in 8.x
I added a warning as you suggested. The full description is now

Thank you @PieterDC for the initial patch. Committed and fixed (although the auto-comment for the commit has not shown up yet).