This module adds «Gmap» component to Webform.
This module one year on sandbox (https://www.drupal.org/node/2097005).

Drupal core version: 7

Project link:
https://drupal.org/sandbox/drecksau/2096563

Git:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/drecksau/2096563.git
webform_gmap_location
cd webform_gmap_location

Comments

drecksau’s picture

drecksau commented
Priority: Major » Normal
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdrecksau2096563git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

drecksau’s picture

drecksau commented
Issue summary: View changes
drecksau’s picture

drecksau commented
Status: Needs work » Needs review

This names function according to instructions webform.

function _webform_defaults_gmap() {
function _webform_theme_gmap() {
function _webform_edit_gmap($component) {
function _webform_render_gmap($component, $value = NULL, $filter = TRUE) {
function _webform_analysis_gmap($component, $sids = array(), $single = FALSE) {
function _webform_table_gmap($component, $value) {
function _webform_csv_headers_gmap($component, $export_options) {
function _webform_csv_data_gmap($component, $export_options, $value) {
function _webform_display_gmap($component, $value, $format = 'html') {

The rest I corrected

moravia’s picture

moravia commented
Status: Needs review » Needs work

Hi,
I have checked functionality of your plugin.

* After submitting the form (only with gmap) I receive following php notices:

Notice: Undefined index: #format in theme_webform_display_textfield() (line 208 of .../drupal/modules/webform/components/textfield.inc).
Notice: Undefined index: #field_prefix in theme_webform_display_textfield() (line 208 of .../drupal/modules/webform/components/textfield.inc).
Notice: Undefined index: #format in theme_webform_display_textfield() (line 209 of .../drupal/modules/webform/components/textfield.inc).
Notice: Undefined index: #field_suffix in theme_webform_display_textfield() (line 209 of .../drupal/modules/webform/components/textfield.inc).
Notice: Undefined index: #format in theme_webform_display_textfield() (line 210 of .../drupal/modules/webform/components/textfield.inc).

However data from the map are successfully saved on database and even sent by email.

* Also if I want to add 2 maps in one form, there is just one map displayed intercactive, the instead of the second one there is just empty space.

drecksau’s picture

drecksau commented
Status: Needs work » Needs review

After submitting the form (only with gmap) I receive following php notices:

Thank you! Fixed.

Also if I want to add 2 maps in one form, there is just one map displayed intercactive, the instead of the second one there is just empty space.

Thank you! Fixed too.

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Needs work

Hi @drecksau,

a) I just tested your module and found out a jQuery error. The steps to reproduce it:

1) Fresh drupal install
2) Create new webform
3) Only create a gmap field with default options
4) Visit webform page
5) This javascript error appears, nothing gets rendered:

Uncaught TypeError: Cannot read property 'lat' of undefined

b)

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements]
Coding style & Drupal API usage
[No]
1. (*) I checked out your code and found out this in top of gmap_page.js file:

var limit_count = {};
var markers = {};

I think you should store your variables inside Drupal global variable like this to avoid collision with other modules:

Drupal.webform_gmap_location = Drupal.webform_gmap_location || {};
Drupal.webform_gmap_location.limit_count = {}
Drupal.webform_gmap_location.markers = {}

c) Keep up the good work!

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.