[D7] Aspose Doc Importer

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxaspose2370925git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Aspose,

Automated reviews
There are many errors reported by automated review tools, did you already check them? See
http://pareview.sh/pareview/httpgitdrupalorgsandboxaspose2370925git

Manual Review
1. Drupal coding standards:
# No Indentation.
# Commented code is present.

2.

  function _aspose_doc_importer_form_builder() {
  ..
  ..
  ...
  $form['#submit'] = array(
    '_aspose_doc_importer_form_submit_special_fuction_name'
  );

form function / submit function should not start with "_". As per my knowledge only helper functions starts with "_".

3.

function _aspose_doc_importer_form_submit_special_fuction_name($form, &$form_state){
    //check $form_state['values'] and use this below line to set the value
    variable_set('_aspose_api_sid_value', $_POST['aspose_api_sid']);
    variable_set('_aspose_api_key_value', $_POST['aspose_api_key']);
}

If $form_state['values'] will provide the submitted values then whats the reason behind to use $_POST.

4.

/**
 * Implements hook_block_info().
 */
function aspose_doc_importer_block_info() {
    $blocks['aspose_doc_importer'] = array(
        // The name that will appear in the block list.
        'info' => t('Aspose DOC Importer module Info Hook'),
        // Default setting.
        //'cache' => DRUPAL_CACHE_PER_ROLE,
        'cache' => DRUPAL_NO_CACHE,
    );
    return $blocks;
}

function hook_block_view() {
    $blocks['aspose_doc_importer'] = array(
        // The name that will appear in the block list.
        'info' => t('My Module from Block View'),
        // Default setting.
        //'cache' => DRUPAL_CACHE_PER_ROLE,
        'cache' => DRUPAL_NO_CACHE,
    );
    return $blocks;
}

Empty Block is created, It does not render anything. hook_block_view() used as it is directly.

Coder Module have a lot complains for base on your module. Mainly is spacing issues. So I would recommend you to install the coder module to auto-format. You can find all the coder complains here.

You should consider adding some useful information on the hook_help something better than

Aspose DOC Importer help

.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No: Does not follow the guidelines for 3rd party assets/code.

PAReview: 3rd party code

Aspose_Cloud_SDK_For_PHP-master appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

README.txt/README.md

No: Does not follow guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

Hook_help does not have it usefull information. This modules does not contain a README.txt or README.md on the module. In addition, this module

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Fixing priority, "Major" is only for issues in Needs Review state that haven't gotten a review in at least 2 weeks.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.