Hi guys,
Great module and fantastic functionality. I especially like the very thorough in-line help with the text format filter settings.
Problem is, I'm in the minority: most of my content maintainers want to hide that enormous chunk of help underneath a [Help] link.
So, this may not be a Flickr module issue...it's just that you guys provide 10x more info than the other filters, so I thought maybe there were some clues here for how to handle it.
Suggestions?
We're using Panopoly with a Radix theme. Content maintenance happens in the Seven theme. We have the Help module enabled.
Any clues or pointers as to how to keep, but hide, the Flickr help notes?

CommentFileSizeAuthor
#4 collapsed_flickr_filter_tips-2365381-4.patch1.63 KBlolandese
#2 collapsed_flickr_filter_tips-2365381-2.patch779 byteslolandese
text-format.png180.31 KBboabjohn

Comments

lolandese’s picture

lolandese commented
Version: 7.x-1.6 » 7.x-1.x-dev
Category: Support request » Feature request

Hi John,

Yes. I agree that the Help text provided is longer than the usual and might be annoying for some users. The suggestion to make it collapsible (collapsed by default) is indeed a good idea.

Ideal would be to use the functionality that is natively present in Drupal core. If you go to the module list (admin/modules) for example, you'll see that clicking a section title will put it in collapsed state. Using the browser inspector you'll find some classes that probably are targeted with some jQuery. A Google search results in several related articles on the subject to explore.

Feel free to go ahead and/or exchange ideas on it here. I can give it a shot in the weekend. In any case, patches are reviewed instantly and always committed with attribution.

Thanks for this useful feature request.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new collapsed_flickr_filter_tips-2365381-2.patch779 bytes

Enable the ctools module and try the patch.

Credits:
http://timonweb.com/painless-collapsible-divs-drupal

boabjohn’s picture

boabjohn commented
Status: Needs review » Reviewed & tested by the community

Hey there @lolandese...applied patch and appears to work as expected. Fantastic and very much appreciated!
Marking RTBC for now.
Cheers!

lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new collapsed_flickr_filter_tips-2365381-4.patch1.63 KB

Attached patch:

  • collapses the filter tips if the ctools is enabled
  • offers a checkbox on the Flickr configuration page to override this default behavior, but again only if the ctools module is enabled
  • wraps the toggle handle in an HTML anchor to apply the CSS for links
  • an override of the ctools CSS (only targeting the filter tips) to suppress the image for the toggle state that overlaps with the list-style bullets.

Ctools is not added as a dependency. Obviously because the module works also without it, just that the Flickr Filter tips wouldn't be collapsed in that case.

  • lolandese committed 256b1bc on 7.x-1.x 
    Issue #2365381 by boabjohn: Collapsible text filter tips on node edit...
lolandese’s picture

lolandese commented
Status: Needs review » Fixed

Tested in the two major browsers. Copy/pasting the working examples from the filter tips to the body field still works.

Nice addition to the module. Thanks again for the suggestion.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.