[D7] Car Rental Module

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxHispacar2358731git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

... to a Joomla website...

o_O WTF?

Automated Review

Showing the json files have some spelling error. According to your previous comment those are false positive. So, skip those.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.
But have problem, have README.txt & README.md both. Also 2 files have different content. So, there should be only 1 file and t should be up to date.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) You have used administer site configuration access argument in car_rental_module_menu() function. But it should be a separate access string for you module. Use hook_permission() function to generate access string.
2. (*) In car_rental_module_render function you have used html to build up the block view. But this html should goes to a tpl file and call the tpl file using the theme function.
3. (*) Don't echo the js codes below the html. use Drupal settings variable to pass settings to js.
4. (*) For js file used Drupal js writing standard. link of example https://www.drupal.org/node/171213
5. (+) In car_rental_module_block_view function access checking for block content is not needed. You can handle the permission on native block settings page.
6. (+) In car_rental_module_render function use 100 as default value for this line $width = variable_get('car_rental_module_width', '0');. Because if any one add this block without set any settings then he will get a broken block.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.