File Usage count for revisions out of sync/incorrect

Please only change the status to "needs review" when you have an actual patch file that needs review. Thanks.

Here is a patch for that.

Hmm, found the issue that the files get deleted.
This is cause of how all the moderation is handled so node->original will be loaded with node_load before setting the "live" revision to the current one.
So doing node_load will load the draft and the draft would be considered the original for the node_save($live_revision); in function workbench_moderation_store which is obviously wrong and not what is wanted.

Does the above patch solve the problem with file usage? I have the exact the same issue and also found that field_attach_update was the cause of the problem, but I'm not sure what purpose the function serves in this module.

As far as I tested locally it does not call field_attach_update so the file usage stays correct. Feel free to test and see if that works for you.

Re-roll of #6.

Seems like a good solution to me, given that field_attach_update() is already called by node_save() before hook_node_update() is invoked; workbench_moderation_node_update() probably shouldn't be calling it again inside the same transaction.

Found the same issue with field collections being not deleted because of this extra revision generated by extra call to field_attach_updated() from workbench_moderation_node_update().
Tested this path, works great.

https://www.drupal.org/node/2353491#comment-9670051

Seems to work well when using "Primary Image" in wetkit - offering a usage of 2 for a translated node.

But when putting WYSIWYG images on the same translated node, the counter increments by 1, not 2. :-(

@fgjohnson Are you sure that last point has anything to do with Workbench Moderation? WYSIWYG editors not being able to correctly record usage of files is a fairly common problem.

This no longer applies to the latest version, unfortunately.

Here are clean rerolls for both the 7.x-1.x and 7.x-3.x branches.

@eelkeblok Re:

WYSIWYG editors not being able to correctly record usage of files is a fairly common problem WYSIWYG habving issues

Good to know.
Thought it was bundled up with everything else.

I'll try your patch and report back.

Patch for 7.x-3.x-dev does not apply cleanly. Referenced code does not exist in the newest release.

I would suspect this would need tests to identify whether or not the problem still exists with the v3 branch, given the major overhaul that went into the 3.0 release.

Just to be clear, someone should write tests that step through what is expected to happen as files are added, then see if the v3 branch still has the bug. Once we have a solid test it'll be easier to fix the problem.

As of version 3.0 I no longer have this issue. Creating new revisions containing the same file increases the file count of a specific file, deleting decreases. Creating a new revision of an existing revision but changing the file creates a new file with a count of 1. So latest version is working good.

We were having the same problem with double rows being created on a single save. Instead of with files, the duplicate rows were with Field Collections. I can confirm that the 3.0 branch fixed the issue for us.

@Gomez_in_the_South: Thanks for the update.

Updated #16 patch to support version 7.x-1.4