Problem/Motivation

The new LanguageItem's value should only be allowed to contain a valid language code. Currently, the property definition of the 'value' property is set to "string". There should be additional logic to capture invalid language codes.

Proposed resolution

See if this can be fixed by implementing a getConstraints() method in the LanguageItem class by using the OptionsProviderInterface.

Remaining tasks

- Write failing test that attempts to set an invalid language code

User interface changes

- None

API changes

- None

Original report by @mauzeh

CommentFileSizeAuthor
#15 2350843-language-field-item-type-15.patch5.72 KBvijaycs85
#15 2350843-diff-13-15.txt1.58 KBvijaycs85
#13 language-item-field-type-2350843-13.patch4.66 KBmauzeh
#7 language-item-field-type-2350843-6.patch6.68 KBmauzeh
#6 language-item-field-type-2350843-6-SHOULD-FAIL.patch2.91 KBmauzeh
#6 language-item-field-type-2350843-6-SHOULD-FAIL.patch2.91 KBmauzeh
#5 language-item-field-type-2350843-5.patch6.6 KBmauzeh
#5 language-item-field-type-2350843-5-SHOULD-FAIL.patch2.91 KBmauzeh
#3 language-item-field-type-2350843-3-SHOULD-FAIL.patch2.91 KBmauzeh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mauzeh’s picture

mauzeh CreditAttribution: mauzeh commented
Issue summary: View changes
mauzeh’s picture

mauzeh CreditAttribution: mauzeh commented

I'm at the sprint at DrupalCon Amsterdam, I'm going to write the test that attempts to set an invalid language code.

mauzeh’s picture

mauzeh CreditAttribution: mauzeh commented
Status: Active » Needs review
FileSize
language-item-field-type-2350843-3-SHOULD-FAIL.patch2.91 KB

Added failing test.

Status: Needs review » Needs work

The last submitted patch, 3: language-item-field-type-2350843-3-SHOULD-FAIL.patch, failed testing.

mauzeh’s picture

mauzeh CreditAttribution: mauzeh commented
FileSize
language-item-field-type-2350843-5-SHOULD-FAIL.patch2.91 KB
language-item-field-type-2350843-5.patch6.6 KB

Added constraint validation.

mauzeh’s picture

mauzeh CreditAttribution: mauzeh commented
Status: Needs work » Needs review
FileSize
language-item-field-type-2350843-6-SHOULD-FAIL.patch2.91 KB
language-item-field-type-2350843-6-SHOULD-FAIL.patch2.91 KB

Changed / improved inline documentation.

mauzeh’s picture

mauzeh CreditAttribution: mauzeh commented
FileSize
language-item-field-type-2350843-6.patch6.68 KB

The last submitted patch, 6: language-item-field-type-2350843-6-SHOULD-FAIL.patch, failed testing.

The last submitted patch, 6: language-item-field-type-2350843-6-SHOULD-FAIL.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: language-item-field-type-2350843-6.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Issue tags: +D8MI, +sprint, +language-base

Adding tags.

Also, I have no clue whether this is a good thing to do or if all hell will break lose, but if we do this, it should be done by having LanguageItem implement OptionsProviderInterface.

yched’s picture

yched CreditAttribution: yched commented
Issue summary: View changes

Updated summary with the OptionsProviderInterface approach.

mauzeh’s picture

mauzeh CreditAttribution: mauzeh commented
Status: Needs work » Needs review
FileSize
language-item-field-type-2350843-13.patch4.66 KB

Rewrote the patch, the LanguageItem now implements OptionsProviderInterface.

I'm not too happy about simply calling \Drupal::service('language_manager'); in order to retrieve the list of allowed languages. Feels dirty to access a global scope. Perhaps there is a better way of doing it?

Status: Needs review » Needs work

The last submitted patch, 13: language-item-field-type-2350843-13.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
2350843-diff-13-15.txt1.58 KB
2350843-language-field-item-type-15.patch5.72 KB

#13 - How about this one?

Status: Needs review » Needs work

The last submitted patch, 15: 2350843-language-field-item-type-15.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

FieldItemBase also uses \Drupal::entityManager() directly already. Don't seem like there would be a way to inject services in a straightforward fashion.

Still several fails on existing tests. EntitiyValidationTest and UserValidationTest. Invalid languages used?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint

Clearly nobody is working on this.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented

Referenced from #2872790: Deprecate \Drupal\Core\Field\FieldItemBase::generateSampleValue.

It seems the only class that is not implementing generateSampleValue is LanguageItem.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.