Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
entity system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
29 Sep 2014 at 13:30 UTC
Updated:
16 Feb 2015 at 12:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
m1r1k commentedComment #2
andypostfix routes for entity view|form displays
Comment #3
andypostMakes sure that entity has bundle, suppose the scope allows
PS: working to fix routes for fields
Comment #4
Crell commentedThis looks fine to me, but it's unclear from the comment in #3 if you are still working on something or if you're clarifying what it's for. :-) Should I RTBC it or is there another patch coming?
Comment #5
andypostPatch is not ready, there's routes for field and field config, also this affects content translation which routes needs some clean-up... see comment in #2281645-81: Make entity annotations use link templates instead of route names
The CT routes are tricky but affected by field_ui so probably better to fit them here too
Comment #6
dawehnerTo be honest I don't get why we want to extract those here as well, given that you have to adapt config translation at the same time as well (yes, believe me).
This issue is for me at least, sorry andypost, a sign of overusing formal issue queue structures/"best" practices.
Comment #7
andypost@dawehner I mostly agree, in my vision routes should be renamed in separate issue under the meta
We need to standardize routes without dependency on link templates.
PS: will back to patch next weekend
Comment #8
andypostI'd still prefer to separate route rename issues from logic changes
Comment #9
Crell commentedSo is another patch forthcoming here?
Comment #10
andypostComment #11
dawehner@andypost
What is the status of the issue? You assigned it to yourself ... but nothing happened. Do you still work on a new version of the patch?
Comment #13
kgoel commentedThis doesn't re-roll as patch still applies but testbot will tell. Correct me if I am wrong but config translation can be address in a separate issue so things can move forward.
Comment #14
dawehnerThe patch still works, let's get it in.
Comment #17
andypostre-roll after #2281645: Make entity annotations use link templates instead of route names
Comment #18
andypost@dawehner is
add-formtemplate is needed?the only missing part in last patch, not sure is needed
Comment #19
dawehnerWe do have at least one call to it:
in
VocabularyListBuilderComment #20
andypostOnce this entities have add forms it makes sense to expose them as templates too
This is just a rename
Comment #21
andypostneeds feedback
Comment #22
dawehner+1
Comment #24
amateescu commentedRerolled.
Comment #25
alexpottThis issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.
I think this is a followup from the critical work on entity url templates so is allowed.
Comment #26
dawehnerAdded it.
Comment #29
andypostComment #30
alexpottI see this as a followup to #2281645: Make entity annotations use link templates instead of route names and therefore committable under the followup rules of beta evaluation. Committed 275de46 and pushed to 8.0.x. Thanks!