[D7] Menu Export

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmax62fr2337365git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Replaced ssh link to http

Installed and used in my last Drupal Project, Thx Max62fr, it was really helpfull to build an homemade deploy module.

Used easily in my deployment of new project. Nice.

Used in my project, Nice module. It would be great if you added the global Import menu button on menu listing page.

@max62fr, thankyou for your contribution.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. None.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

(*) May Be: Does not cause module duplication and fragmentation.
I am not sure how your module aim is different from Menu Export/Import module. Menu Export/Import is already gives both features that you are providing, just changing the export file syntax doesn't make sense to me. If you are providing some additional feature or it is more useful from performance prospective or anything else then elaborate the same on your project page. If you give genuine reasons, it would help other people why they prefer your module instead Menu Export/Import.

I still feel in what scenario this module is preferable instead of Menu Export/Import. I am sure you gone through some business use cases where you get such type of requirement, do share here.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

1. (*) You missed a t() on the #title in menu_export_list_export_form() on line 40.
2. hook_help() is missing in your module.
3. (+) menu_export_menu_import(): I'm not sure, why are you not providing import functionality in admin interface. Instead you are giving some tips and example in README file to import that cause a site admin who don't know how to write php code, can't import this menu. There is a possibility, i'm missing something here so please add your comment on this. Again
4. (*) menu_export_export_form(): $menu_name = arg(4); is not a recommended approach.
   Instead of

   $items['admin/structure/menu/manage/%/export'] = array(
       'title' => 'Menu export',
       'page callback' => 'drupal_get_form',
       'page arguments' => array('menu_export_export_form'),
       'access arguments' => array("administer menu"),
       'type' => MENU_LOCAL_TASK,
       'weight' => 11,
     );
   
   function menu_export_export_form($form, &$form_state) {
     $menu_name = arg(4);
   
   }
   

   Use following (page arguments):

   $items['admin/structure/menu/manage/%/export'] = array(
       'title' => 'Menu export',
       'page callback' => 'drupal_get_form',
       'page arguments' => array('menu_export_export_form', 4),
       'access arguments' => array("administer menu"),
       'type' => MENU_LOCAL_TASK,
       'weight' => 11,
     );
   
   function menu_export_export_form($form, &$form_state, $menu_name) {
       $elements = menu_tree_all_data($menu_name);
   }
   

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Thanks Again!

Automated Review

Yes.

http://pareview.sh/pareview/httpgitdrupalorgsandboxmax62fr2337365git-0
Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No. Similar module exists. https://www.drupal.org/project/menu_import : Does not cause module duplication and fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

1. (*) Major finding

   While importing a menu into the system, validation should be placed inside menu_export_import_form_validate instead of menu_export_import_form_submit.

   I tried importing an already existing menu and got an error message. But my Menu code has been removed.

   Screenshots attached.
   

   

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

> A similar module exists, it's Menu Import, the biggest difference is on the exported result file.
Menu Export creates an StdClass Object and the other module creates a text file with json inside.

If that's the biggest difference then you should really consider joining forces with that module rather than creating duplication.

What's the benefit of having an object over json? Surely if you're using it to export/import, the format is immaterial as long as you can copy-paste it from one site to another.

> We would recommend you to use Menu Export if you need something to deploy faster your project.

Why is using Menu Export faster?

Make this module compatible with drush :

Menu Export/Import also compatible with Drush. Still not convinced from your explanation how your module is faster from existing one, even faster doesn't make any sense, as it is just export/import task.

Nethertheless you should probably have a look to Menu Export/Import if you need something readable and understandable by non-tech person.

What do you mean here from non-tech person? Is your module not useful for Non Technical people?

Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.