Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Hi ezra-g,
I was thinking to create another sub-module for showing only published nodes in autocomplete while adding nodes in nodequeue.
But thought that if I can give a setting in nodequeue interface and do the same thing, if you are ok with this. Then there shouldn't be requirement of extra module.
I will submit a patch over here. After that, Please let me know about it.
Please do reply on this thread as this is very important for me. :)
Cheers,
Deepak Kumar
Comment | File | Size | Author |
---|---|---|---|
#24 | show_published_nodes-2327159-24.patch | 5.89 KB | Vj |
#19 | show_only_published-2327159-16.patch | 3.14 KB | fizk |
#15 | show_only_published-2327159-15.patch | 2.75 KB | fizk |
#9 | interdiff.txt | 2.89 KB | visabhishek |
#9 | show_only_published-2327159-9.patch | 2.42 KB | visabhishek |
Comments
Comment #1
visabhishek CreditAttribution: visabhishek commentedI have created a patch for providing this facility from Admin UI.
Please Run Update and then visit Check "Show Only Published Node in Autocomplete" on
admin/structure/nodequeue/%/edit page.
Please review
Comment #3
visabhishek CreditAttribution: visabhishek commentedComment #4
visabhishek CreditAttribution: visabhishek at Azri Solutions commentedUpdated patch for Version: 7.x-2.0.
Please review
Comment #5
visabhishek CreditAttribution: visabhishek at Azri Solutions commentedConfiguration screenshot is attached for Show only Published nodes in autocomplete.
Comment #6
deepakaryan1988Great but I have already published along back.
But if this feature is pushed to nodequeue, then I will remove my module with status that "this feature has implemented in new nodequeue version".
Comment #7
subhojit777Comment #8
subhojit777Patch in #4 is working. We need to update the patch based on the following:
Change this to "Allow only published nodes"
I think we don't require this. The new title itself tells it's purpose.
Incorrect capitalization
Add description.
Incorrect indentation and whitespace.
Incorrect indentation and whitespace.
Comment #9
visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commentedAs per #8 i updated the patch. Please review once
Comment #14
Bohus UlrychHi, thank you for great work.
I know that this ticket is about the autocomplete but I think that it would be really nice to consider also the node status on the list of nodes for selected subqueue, not only for the autocomplete.
Let's imagine that I have published node, which I put to the queue, but later I unpublish this node. It will be still visible in in queue list.
What do you think?
Thanks
Comment #15
fizk CreditAttribution: fizk commented@Bohus That's an interesting feature request. It seems there could be a great many reasons to limit certain nodes from joining a queue.
Maybe a generalized filtering system would help. For example, filtering by a view - i.e. you create a view that accepts a node as an argument, and either displays the node ID if the node should be included in the nodequeue, or doesn't display the node id, thus, indicating the node should not be inserted into the nodequeue.
Either way, we should discuss that feature request in a new issue. If you can create a new issue and paste the link here, that would be great!
Edit: See #2787237: Restrict nodes by Views
Comment #19
fizk CreditAttribution: fizk commentedFix automated tests.
Comment #20
fizk CreditAttribution: fizk commented@visabhishek Thanks for your work. Can you add some automated tests and then I can commit!
Comment #21
fizk CreditAttribution: fizk commentedComment #22
Bohus UlrychHello @fizk, patch #19 it seems to be working well.
Thank you!
Comment #23
dmkelner CreditAttribution: dmkelner at Sleight-of-Hand Studios LLC commentedIs this patch being committed? Very useful.
Comment #24
Vj CreditAttribution: Vj as a volunteer commentedWhy "publish only" for autocomplete only ? If we need to add this functionality then it should be for all source from where we can add nodes to nodequeue, otherwise it will be confusing how unpublished node listed into nodequeue which is marked as "publish only".
I have created a small patch using above comments/patches.
Please review and share your thoughts.