When I created a field group "Bootstrap nav:tabs/pills" with "Nav type" is "tabs", the default tabs isn't displayed as active (with border) for the first time when I visited.

CommentFileSizeAuthor
#18 bootstrap_fieldgroup-current_tab_isnt_active_for_first_time-2313709-18.patch710 bytesjurgenhaas
#1 bootstrap_fieldgroup-current_tab_isnt_active_for_first_time-2313709-1.patch643 bytestrunghaiy

Comments

trunghaiy’s picture

trunghaiy commented
StatusFileSize
new bootstrap_fieldgroup-current_tab_isnt_active_for_first_time-2313709-1.patch643 bytes

Patch attached, I just add a space between classes in templates/bootstrap-fieldgroup-nav.tpl.php

milesw’s picture

milesw commented
Status: Active » Reviewed & tested by the community

Same issue here and patch fixes it, thanks.

Since this is so minor let's mark as RTBC.

ckng’s picture

ckng
Primary language English
commented
Assigned: trunghaiy » Unassigned

Patch #1 works well.

mkhamash’s picture

mkhamash commented

RTBC this should be committed.

Christopher Riley’s picture

Christopher Riley commented

I agree commit this it took care of my issue.

cha0s’s picture

cha0s commented
Status: Reviewed & tested by the community » Closed (fixed)

Committed, thanks everyone

cha0s’s picture

cha0s commented
Status: Closed (fixed) » Fixed

  • ckng committed cfe5a8c on 7.x-1.x authored by trunghaiy 
    Issue #2313709 by trunghaiy: Current tab isn't active for first time
ckng’s picture

ckng
Primary language English
commented

This was not committed. Re-commit again.

cha0s’s picture

cha0s commented

It was committed under 620eecebbfae1b8b2ee5523daa14bafc5a35eca6, I was committing under master and not 7.x-1.x branch though. That was my bad. I'm going to get it merged now.

  • cha0s committed 620eece on 7.x-1.x authored by trunghaiy 
    Issue #2313709 by trunghaiy, milesw, ckng, mkhamash: Current tab isn't...
ckng’s picture

ckng
Primary language English
commented

Commit 0779cfad breaks this again.

  • ckng committed 2f4e2a4 on 7.x-1.x 
    Issue #2313709 by ckng: reapply overwritten commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

guedressel’s picture

guedressel commented
Status: Closed (fixed) » Needs work

Issue still exists for me.
Just downloaded v1.2 and activated some tabs the first time :-(

duntuk’s picture

duntuk commented

Just add the following to the "Extra CSS classes":

active

Make sure you add trailing space after "active " or any last class you place in there... Otherwise it'll look like this

activeactive

simone960’s picture

simone960 commented

Version 1.2 still has this issue. Means the patch not yet applied to 1.2. @duntuk's solution works for me :)

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
StatusFileSize
new bootstrap_fieldgroup-current_tab_isnt_active_for_first_time-2313709-18.patch710 bytes

Re-rolled patch

adam-delaney’s picture

adam-delaney commented
Status: Needs work » Reviewed & tested by the community

Patch #18 worked for me and the code looks pretty straight forward. Let's get this committed.

drcolossos’s picture

drcolossos commented

#18 works for me as well

ckng’s picture

ckng
Primary language English
commented
Status: Reviewed & tested by the community » Closed (fixed)

This is already fixed in dev in #12, but not yet tagged for release.
To avoid the confusion, I've created a dev release.

kmajzlik’s picture

kmajzlik commented

Please create new stable release - it is confusing to remember "i need dev version of ... before..." for each new site.

wavesailor’s picture

wavesailor commented

I second @karlos007 requested to create a new stable release. Thanks